Load filtered device history with htmx#3663
Merged
Conversation
c059843 to
9ab023b
Compare
Test results 27 files 27 suites 45m 18s ⏱️ Results for commit a0464d9. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3663 +/- ##
=======================================
Coverage 63.02% 63.02%
=======================================
Files 612 612
Lines 45226 45228 +2
Branches 43 43
=======================================
+ Hits 28503 28505 +2
Misses 16713 16713
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ceb0f40 to
a0464d9
Compare
a0464d9 to
6709a3f
Compare
6709a3f to
dae3d23
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Scope and purpose
I noticed that the entire device history page is refreshed when changing filters. This is both unnecessary and causes a brief "flicker" after clicking "filter".
This PR loads filtered results with HTMX, and reuses the existing
devicehistory_viewby returning a partial for HTMX requests.Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.