Replace broken tooltips in devicehistory and subnet matrix#3591
Merged
Replace broken tooltips in devicehistory and subnet matrix#3591
Conversation
f430b4c to
5c69fe1
Compare
|
Test results 27 files 27 suites 45m 46s ⏱️ Results for commit 5c69fe1. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3591 +/- ##
=======================================
Coverage 62.21% 62.21%
=======================================
Files 611 611
Lines 44939 44939
Branches 43 43
=======================================
Hits 27960 27960
Misses 16969 16969
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
johannaengland
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Scope and purpose
While upgrading jQuery libraries, I discovered that these two tools had broken tooltips still referring to Foundation code. I'm hoping this is the absolute last instances of surprise Foundation 🤞
This pull request
The tooltip in Subnet Matrix was replaced with a popover, as it contains links and tooltips are not clickable/persistent elements. As such, a popover is more suited for rendering information with an interactive graph (sparklines).
How to test and screenshots
Device History
Before (Branch: 5.14.x)
After
Subnet Matrix
Before (Branch: 5.14.x)
After
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.