Restart Interfaces in Portadmin fails#3589
Merged
Conversation
3364135 to
07b1bab
Compare
Test results 27 files 27 suites 45m 48s ⏱️ Results for commit 6354c36. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3589 +/- ##
=======================================
Coverage 62.49% 62.49%
=======================================
Files 611 611
Lines 45020 45020
Branches 43 43
=======================================
Hits 28137 28137
Misses 16873 16873
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
07b1bab to
6354c36
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Scope and purpose
During testing of #3545, @johannaengland discovered that the restarting interfaces progress fails, leaving a modal that does not close. This PR fixes the bug by ensuring that all code properly awaits creation of new elements, http requests and dom updates.
In addition, this PR replaces the
(why?)tooltip with a toggleable message panel (see image below). This was done as there are issues with displaying the tooltip (which as positioned fixed) within the modal element (which is also fixed). A follow-up task is to investigate whether we can support fixed tooltips in modals as well, but I opted for this solution instead of spending too much time. I also think that this is a more user-friendly solution than displaying a large tooltip within a modal element.A message panel is shown when clicking on the

(why?)elementHow to test
This pull request
(why?)tooltip to a message panel for functional and usability reasonsContributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.