Skip to content

Upgrade tinysort library#3580

Merged
Simrayz merged 2 commits intomasterfrom
chore/upgrade-tinysort-library
Oct 10, 2025
Merged

Upgrade tinysort library#3580
Simrayz merged 2 commits intomasterfrom
chore/upgrade-tinysort-library

Conversation

@Simrayz
Copy link
Copy Markdown
Contributor

@Simrayz Simrayz commented Oct 9, 2025

Scope and purpose

While working on upgrading jquery (due to security warnings, #2291), I found that jquery.tinysort had been updated to no longer have a jQuery dependency at all. As such, this PR adds the new standalone tinysort dependency.

The library was only used in the multiple_select plugin, which in turn was only used in info_netboxgroup.js.

How to test

  1. Search for a device group, and open it in edit mode. E.g. /search/devicegroup/ACCESS/edit/
  2. Select options in "Devices not in group", and check that they appear in sorted (alphabetical) order in "Devices in group".
  3. Select options in "Devices in group", and verify that they disappear from the list and appear in sorted (alphabetical) order in "Devices not in group".

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • Wrote the commit message so that the first line continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • Based this pull request on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If it's not obvious from a linked issue, described how to interact with NAV in order for a reviewer to observe the effects of this change first-hand (commands, URLs, UI interactions)
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this adds a new Python source code file: Added the boilerplate header to that file

@Simrayz Simrayz self-assigned this Oct 9, 2025
@Simrayz Simrayz added the dependencies Pull requests that update a dependency file label Oct 9, 2025
@Simrayz Simrayz requested a review from a team October 9, 2025 09:09
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 9, 2025

@Simrayz Simrayz changed the title Update tinysort library Upgrade tinysort library Oct 9, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2025

Test results

    27 files      27 suites   45m 3s ⏱️
 2 586 tests  2 586 ✅ 0 💤 0 ❌
19 078 runs  19 078 ✅ 0 💤 0 ❌

Results for commit 27014b1.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.20%. Comparing base (12c53ba) to head (27014b1).
⚠️ Report is 300 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3580      +/-   ##
==========================================
- Coverage   62.21%   62.20%   -0.02%     
==========================================
  Files         611      611              
  Lines       44939    44939              
  Branches       43       43              
==========================================
- Hits        27960    27955       -5     
- Misses      16969    16974       +5     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Simrayz Simrayz mentioned this pull request Oct 10, 2025
10 tasks
@Simrayz Simrayz merged commit 843ca70 into master Oct 10, 2025
20 checks passed
@Simrayz Simrayz deleted the chore/upgrade-tinysort-library branch October 10, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants