Conversation
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3307 +/- ##
==============================
==============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lunkwill42
left a comment
There was a problem hiding this comment.
Thanks for the contrib, @Slenderman00! 👍
As I am wont to do, I have some nitpicks before we'll accept this into NAV upstream:
- SonarCloud is rightly complaining about missing docstrings in your module and class. Something should be done about that.
- The new MIB is not added to the
[sensors:vendormibs]section of theipdevpoll.confdefaults, so it will never be used. Seenav.ipdevpoll.config.IpdevpollConfig- In fact, the example
ipdevpoll.conffile is supposed to reflect the default vendormibs in its comments, but it seems we've forgotten to add COMETMS-MIB to the example file, while it has been added to the actual defaults in the module above. This is your chance to fix both issues 😁
- In fact, the example
Also see my inline comments.
|
|
Thank you for the great feedback @lunkwill42 I have resolved the issues now. |
b3d272f to
9b1964e
Compare
9b1964e to
cdd9d72
Compare
|
Adds support for the Comet T3611 sensor by introducing a new mibretriever and smidump