Make it possible to download a ZIP file containing QR codes of bulk selected netboxes/rooms#2899
Merged
johannaengland merged 3 commits intoUninett:masterfrom Aug 12, 2025
Conversation
afdc234 to
1bfc71e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2899 +/- ##
==========================================
+ Coverage 60.87% 60.89% +0.01%
==========================================
Files 607 607
Lines 43953 43994 +41
Branches 48 48
==========================================
+ Hits 26758 26790 +32
- Misses 17183 17192 +9
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d21e516 to
17bc18f
Compare
17bc18f to
9d4bb24
Compare
9d4bb24 to
f75b9eb
Compare
f75b9eb to
2be6e05
Compare
|
|
2be6e05 to
fb3e170
Compare
fb3e170 to
8567928
Compare
8567928 to
3ad0cc9
Compare
|
12dce3f to
eb6af1e
Compare
eb6af1e to
dc570c8
Compare
abfebcd to
81d9f75
Compare
352ad68 to
35b2469
Compare
35b2469 to
98b6d47
Compare
Contributor
Author
|
Needed to rebase on #2897 since it changes some function signatures that are also used in here |
50eccc0 to
42247b0
Compare
6 tasks
42247b0 to
14681ed
Compare
lunkwill42
approved these changes
Aug 11, 2025
Member
lunkwill42
left a comment
There was a problem hiding this comment.
Works for me :)
If you did integrate @jorund1's code, however, you should credit him with a Co-authored-by signature.
Co-authored-by: Jørund Hellebø <jorund.hellebo@sikt.no>
Co-authored-by: Jørund Hellebø <jorund.hellebo@sikt.no>
14681ed to
8a5d8a4
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last step to #2586. Dependent on #2897.
Screenshots - before and after
Before:
After: