views/wizards/host-integrations/rocket-instructions.php (1)

1-118: Rocket instructions template looks solid; consider simplifying one i18n string.

Markup, escaping, and link attributes all look good and consistent with the rest of the plugin. The only minor nit is Line 12: the sentence is composed from several small esc_html_e() fragments, which can make accurate translations harder in languages with different word order.

If you care about top‑quality translations, consider switching that first paragraph to a single translatable string with placeholders (e.g., via printf), so translators see the whole sentence at once. This is purely optional; the current code is safe and functional.

inc/integrations/host-providers/class-rocket-host-provider.php (3)

70-80: detect() may break on PHP 7.4 due to str_contains; consider a strpos-based implementation.

str_contains() is only available on PHP 8+. If Ultimate Multisite still supports PHP 7.4, this will cause a fatal error when the file is loaded. A simple, compatible alternative is to base this on strpos():

 	public function detect(): bool {
 
-		return str_contains(ABSPATH, 'rocket.net') || str_contains(ABSPATH, 'rocketdotnet');
+		$path = (string) ABSPATH;
+
+		return (false !== strpos($path, 'rocket.net')) || (false !== strpos($path, 'rocketdotnet'));
 	}

If the plugin has officially dropped support for PHP < 8.0, you can ignore this, but it’s worth double‑checking your stated minimum PHP version.

---

119-175: Use $site_id in domain logs to address PHPMD warnings and improve diagnostics.

$site_id is currently unused in on_add_domain() and on_remove_domain(), which PHPMD correctly flags. It’s also useful context in logs when troubleshooting mapping issues. You can incorporate it into the existing log messages, e.g.:

 	public function on_add_domain($domain, $site_id): void {
@@
-		if (is_wp_error($response)) {
-			wu_log_add('integration-rocket', sprintf('[Add Domain] %s: %s', $domain, $response->get_error_message()), LogLevel::ERROR);
-		} else {
+		if (is_wp_error($response)) {
+			wu_log_add(
+				'integration-rocket',
+				sprintf('[Add Domain] %s (site %d): %s', $domain, $site_id, $response->get_error_message()),
+				LogLevel::ERROR
+			);
+		} else {
@@
-			if (200 === $response_code || 201 === $response_code) {
-				wu_log_add('integration-rocket', sprintf('[Add Domain] %s: Success - %s', $domain, $response_body));
-			} else {
-				wu_log_add('integration-rocket', sprintf('[Add Domain] %s: Failed (HTTP %d) - %s', $domain, $response_code, $response_body), LogLevel::ERROR);
+			if (200 === $response_code || 201 === $response_code) {
+				wu_log_add(
+					'integration-rocket',
+					sprintf('[Add Domain] %s (site %d): Success - %s', $domain, $site_id, $response_body)
+				);
+			} else {
+				wu_log_add(
+					'integration-rocket',
+					sprintf('[Add Domain] %s (site %d): Failed (HTTP %d) - %s', $domain, $site_id, $response_code, $response_body),
+					LogLevel::ERROR
+				);
 			}
 		}
 	}
@@
 	public function on_remove_domain($domain, $site_id): void {
@@
-		if (! $domain_id) {
-			wu_log_add('integration-rocket', sprintf('[Remove Domain] %s: Domain not found on Rocket.net', $domain), LogLevel::WARNING);
+		if (! $domain_id) {
+			wu_log_add(
+				'integration-rocket',
+				sprintf('[Remove Domain] %s (site %d): Domain not found on Rocket.net', $domain, $site_id),
+				LogLevel::WARNING
+			);
@@
-		if (is_wp_error($response)) {
-			wu_log_add('integration-rocket', sprintf('[Remove Domain] %s: %s', $domain, $response->get_error_message()), LogLevel::ERROR);
-		} else {
+		if (is_wp_error($response)) {
+			wu_log_add(
+				'integration-rocket',
+				sprintf('[Remove Domain] %s (site %d): %s', $domain, $site_id, $response->get_error_message()),
+				LogLevel::ERROR
+			);
+		} else {
@@
-			if (200 === $response_code || 204 === $response_code) {
-				wu_log_add('integration-rocket', sprintf('[Remove Domain] %s: Success - %s', $domain, $response_body));
-			} else {
-				wu_log_add('integration-rocket', sprintf('[Remove Domain] %s: Failed (HTTP %d) - %s', $domain, $response_code, $response_body), LogLevel::ERROR);
+			if (200 === $response_code || 204 === $response_code) {
+				wu_log_add(
+					'integration-rocket',
+					sprintf('[Remove Domain] %s (site %d): Success - %s', $domain, $site_id, $response_body)
+				);
+			} else {
+				wu_log_add(
+					'integration-rocket',
+					sprintf('[Remove Domain] %s (site %d): Failed (HTTP %d) - %s', $domain, $site_id, $response_code, $response_body),
+					LogLevel::ERROR
+				);
 			}
 		}
 	}

This both satisfies the static analysis warning and gives you more actionable logs when something goes wrong. Based on static analysis hints.

---

187-205: Log subdomain no‑op handlers to use parameters and clarify behavior.

on_add_subdomain() and on_remove_subdomain() intentionally do nothing, but PHPMD warns about unused $subdomain and $site_id. Adding a debug‑level log clarifies the no‑op behavior and marks parameters as used:

 	public function on_add_subdomain($subdomain, $site_id) {
-		// Rocket.net manages subdomains automatically via wildcard SSL
-		// No action needed
+		// Rocket.net manages subdomains automatically via wildcard SSL.
+		// Log and return so behavior is explicit and parameters are used.
+		wu_log_add(
+			'integration-rocket',
+			sprintf('[Add Subdomain] %s (site %d): no action required, handled via wildcard SSL.', $subdomain, $site_id),
+			LogLevel::DEBUG
+		);
 	}
@@
 	public function on_remove_subdomain($subdomain, $site_id) {
-		// Rocket.net manages subdomains automatically via wildcard SSL
-		// No action needed
+		// Rocket.net manages subdomains automatically via wildcard SSL.
+		// Log and return so behavior is explicit and parameters are used.
+		wu_log_add(
+			'integration-rocket',
+			sprintf('[Remove Subdomain] %s (site %d): no action required, handled via wildcard SSL.', $subdomain, $site_id),
+			LogLevel::DEBUG
+		);
 	}

This should resolve the PHPMD UnusedFormalParameter warnings and provide useful traceability for subdomain events. Based on static analysis hints.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro