inc/class-orphaned-users-manager.php (2)

232-279: Avoid O(users × sites) meta lookups; compute in bulk

Current approach loops every user across every site, doing many usermeta reads. For large networks this will be slow.

Option A (single query + set diff):

• Build one DISTINCT list of user_ids having any “{base_prefix}%_capabilities” meta.
• Orphaned users = all users – super admins – users_with_roles.

Sketch:

$cap_like = $wpdb->esc_like($wpdb->base_prefix) . '%_capabilities';
$with_roles = $wpdb->get_col( $wpdb->prepare(
    "SELECT DISTINCT user_id FROM $wpdb->usermeta WHERE meta_key LIKE %s", $cap_like
) );
$all = get_users(['fields' => ['ID','user_login','user_email','user_registered'], 'number' => 0]);
$orphans = array_filter($all, fn($u) => !is_super_admin($u->ID) && !in_array($u->ID, $with_roles, true));

Also, use 'number' => 0 (or omit it) instead of empty string for clarity.

---

246-252: Nit: normalize get_users number param

Use 0 (no limit) or omit the param; an empty string is ambiguous.

-        $users = get_users(
-            [
-                'number' => '',
-                'fields' => ['ID', 'user_login', 'user_email', 'user_registered'],
-            ]
-        );
+        $users = get_users([
+            'number' => 0,
+            'fields' => ['ID', 'user_login', 'user_email', 'user_registered'],
+        ]);

inc/managers/class-signup-fields-manager.php (1)

40-45: Docs/filter name mismatch.

Docblock mentions wu_checkout_forms_field_types, code uses wu_checkout_field_types. Align or add an alias to avoid confusion.

Also applies to: 93-94

inc/checkout/signup-fields/class-signup-field-email-confirmation.php (4)

109-112: Icon class likely invalid.

dashicons-wu-at-sign mixes prefixes. Use a core dashicon or a valid wu-dashicon-* class.

Apply this diff (example using a core icon):

-    return 'dashicons-wu-at-sign';
+    return 'dashicons-email';

---

245-248: Avoid undefined index notices for builder attrs.

Use safe accessors for optional name/placeholder/tooltip.

Apply this diff:

-                'name'              => $attributes['name'],
-                'placeholder'       => $attributes['placeholder'],
-                'tooltip'           => $attributes['tooltip'],
+                'name'              => wu_get_isset($attributes, 'name', __('Email Address', 'multisite-ultimate')),
+                'placeholder'       => wu_get_isset($attributes, 'placeholder', ''),
+                'tooltip'           => wu_get_isset($attributes, 'tooltip', ''),

---

242-255: Improve UX: add autocomplete and keep parity between fields.

Add autocomplete="email" to both inputs; keep existing attrs intact.

Apply this diff:

         $checkout_fields['email_address'] = [
             'type'              => 'email',
             'id'                => 'email_address',
             'name'              => wu_get_isset($attributes, 'name', __('Email Address', 'multisite-ultimate')),
             'placeholder'       => wu_get_isset($attributes, 'placeholder', ''),
             'tooltip'           => wu_get_isset($attributes, 'tooltip', ''),
             'value'             => $this->get_value(),
             'required'          => true,
             'wrapper_classes'   => wu_get_isset($attributes, 'wrapper_element_classes', ''),
             'classes'           => wu_get_isset($attributes, 'element_classes', ''),
             'wrapper_html_attr' => [
                 'style' => $this->calculate_style_attr(),
             ],
+            'html_attr' => [
+                'autocomplete' => 'email',
+            ],
         ];

         $checkout_fields['email_address_confirmation'] = [
             'type'              => 'email',
             'id'                => 'email_address_confirmation',
             'name'              => wu_get_isset($attributes, 'confirmation_label', __('Confirm Email Address', 'multisite-ultimate')),
             'placeholder'       => wu_get_isset($attributes, 'confirmation_placeholder', __('Re-enter your email address', 'multisite-ultimate')),
             'tooltip'           => __('Please re-enter your email address to confirm it matches.', 'multisite-ultimate'),
             'value'             => '',
             'required'          => true,
             'wrapper_classes'   => wu_get_isset($attributes, 'wrapper_element_classes', ''),
             'classes'           => wu_get_isset($attributes, 'element_classes', ''),
             'wrapper_html_attr' => [
                 'style' => $this->calculate_style_attr(),
             ],
             'html_attr' => [
                 'data-confirm-email' => 'email_address',
+                'autocomplete'       => 'email',
             ],
         ];

Also applies to: 257-273

---

153-159: Guard against duplicate IDs when both Email and Email Confirmation fields are added.

force_attributes() fixes the ID to email_address. If admins also add the base Email field, IDs will collide. Consider runtime validation or UI guard to disallow both simultaneously.

Also applies to: 242-274

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro