Skip to content

Add digest authentication support#201

Merged
Ullaakut merged 2 commits intomasterfrom
add-digest-auth-support
May 22, 2019
Merged

Add digest authentication support#201
Ullaakut merged 2 commits intomasterfrom
add-digest-auth-support

Conversation

@Ullaakut
Copy link
Copy Markdown
Owner

@Ullaakut Ullaakut commented May 21, 2019

Goal of this PR

This PR adds automatic authentication type detection and adds support for the digest authentication type. It also slightly updates the attack summary to integrate those new features.

Fixes #199

How to test it

  • docker run --rm -e RTSP_PASSWORD="admin" -e RTSP_AUTHENTICATION_METHOD="basic" -e RTSP_USERNAME="admin" -p 8554:8554 ullaakut/rtspatt
  • docker run --net=host -t cameradar -t localhost
  • Cameradar should successfully access the camera and display its authentication type as basic
  • docker run --rm -e RTSP_PASSWORD="admin" -e RTSP_AUTHENTICATION_METHOD="digest" -e RTSP_USERNAME="admin" -p 8554:8554 ullaakut/rtspatt
  • docker run --net=host -t cameradar -t localhost
  • Cameradar should successfully access the camera and display its authentication type as digest
  • docker run --rm -p 8554:8554 ullaakut/rtspatt
  • docker run --net=host -t cameradar -t localhost
  • Cameradar should successfully access the camera and show that it does not require authentication

TODO

  • Add unit tests
  • Add default aiphone camera credentials

Screenshots

Screenshot 2019-05-21 at 10 38 16 AM

Screenshot 2019-05-21 at 10 38 38 AM

@Ullaakut Ullaakut added binary feature Feature request/implementation. labels May 21, 2019
@Ullaakut Ullaakut self-assigned this May 21, 2019
@coveralls

This comment has been minimized.

@Ullaakut Ullaakut merged commit 862e9f3 into master May 22, 2019
@Ullaakut Ullaakut deleted the add-digest-auth-support branch May 22, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Feature request/implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement digest authentication

2 participants