feat(financial-templates): adds a new price feed for the DefiPulseTotalTVL synthetic tokens by bryanjcampbell1 · Pull Request #2346 · UMAprotocol/protocol

bryanjcampbell1 · 2020-12-23T18:15:26Z

Title

feat(financial-templates): adds a new price feed for the DefiPulseTotalTVL synthetic tokens

Motivation

UMIP 24 introduces DefiPulseTotalTVL as a price id. The price feed suggested in this PR would allow for the creation of liquidation and dispute bots for the DefiPulseTotalTVL price id.

Summary

Adds the DefiPulseTotalTVLPriceFeed.js file to the financial-templates repo

Details

This price feed was modified from, and closely follows, the CryptoWatchPriceFeed. The cryptowatch api has been replaced with the DeFi Pulse Data API.

Issue(s)

Fixes the current lack of a price feed for the DefiPulseTotalTVL price id.

chrismaree

This looks like a great starting point! I've left some nits on formatting and input validation.

You should try to write some unit tests the same way we have unit tests for the cryptoWatchPriceFeed which you can see here: https://github.com/UMAprotocol/protocol/blob/master/packages/financial-templates-lib/test/price-feed/CryptoWatchPriceFeed.js

Also, to get this feed 100% integrated into this repo we will need an integration made to the CreatePriceFeed file. You can see the similar setup in this file for CryptoWatch here:

protocol/packages/financial-templates-lib/src/price-feed/CreatePriceFeed.js

Line 14 in 898a6fe

if (config.type === "cryptowatch") {

This will also contain some input validation using the isMissingField method, specifically for the apiKey.

chrismaree · 2020-12-28T07:41:54Z

packages/financial-templates-lib/src/price-feed/DefiPulseTotalTVLPriceFeed.js

+const { parseFixed } = require("@ethersproject/bignumber");
+
+// An implementation of PriceFeedInterface that uses DefiPulse Data api to retrieve prices.
+class DEFI_PULSE_TOTAL_TVL_PriceFeed extends PriceFeedInterface {


nit: while the price feed is indeed called DEFI_PULSE_TOTAL_TVL This class should not be named like this. Ideally, it should be called DefiPulsePriceFeed I believe.

Using DefiPulseTotalPriceFeed so I can differentiate between it and the SUSHI/UNI TVL price feed in the future

chrismaree · 2020-12-28T07:44:36Z

packages/financial-templates-lib/src/price-feed/DefiPulseTotalTVLPriceFeed.js

+
+    let closestTime = {timestamp:0, value:0};
+
+    //go through all values and find time that that is the largest and still less than 'time'


nit: here (and in other places) it does not seem you've linted your code correctly. We normally have spaces after // in the comments. You should try running the linter with yarn lint-fix to address these formatting issues.

Is there a config file with a preferred linter settings somewhere in the repo? Im getting Command "lint-fix" not found when running yarn lint-fix

did you install all the packages within the repo by running yarn in the root of the repo? it should work fine once you have done such.

Got it. Thanks

chrismaree · 2020-12-28T07:54:58Z

packages/financial-templates-lib/src/price-feed/DefiPulseTotalTVLPriceFeed.js

+    this.logger = logger;
+    this.web3 = web3;
+
+    this.apiKey = apiKey;


you might want to verify that there is indeed an API key added in here. If there is not, then this price feed will error out. This differs from the CryptoWatchPriceFeed as in those feeds the API key is optional whereas here it is a requirement.

You can simply do this with an assert(apiKey, "requires apiKey for Defi Pulse"); after importing const assert = require("assert");

chrismaree · 2020-12-28T07:55:18Z

packages/financial-templates-lib/src/price-feed/DefiPulseTotalTVLPriceFeed.js

+        closestTime.value = val;
+
+      }
+


similar nit about formatting. Should be resolved once you run the linter.

chrismaree · 2020-12-28T07:55:48Z

packages/financial-templates-lib/src/price-feed/DefiPulseTotalTVLPriceFeed.js

+    `https://data-api.defipulse.com/api/v1/defipulse/api/MarketData?api-key=${this.apiKey}`;
+
+    // 2. Send requests.
+    const [priceResponse] = await Promise.all([


nit: no point in using Promise.all synthax here seeing you are only sending out one async call.

mrice32

This looks awesome! One comment about caching of historical data. It would also be great to see a few tests added to verify the behavior of this class!

Thanks for working on this!

mrice32 · 2021-01-05T05:01:04Z

packages/financial-templates-lib/src/price-feed/DefiPulseTotalTVLPriceFeed.js

+
+    // 1. Construct URLs.
+    const priceUrl =
+    `https://data-api.defipulse.com/api/v1/defipulse/api/MarketData?api-key=${this.apiKey}`;


Is there any way to get historical data from defi pulse? It seems as if this class is depending on caching historical data over time internally, but generally the bots expect to be able to immediately access historical data up to the lookback. Does DefiPulse offer any API for immediate historical data?

There is a GetHistory endpoint. How should I go about using it? Call it from getCurrentPrice() and store it in state so it can be referenced in getHistoricalPrice(time)?

Modifying the CryptoWatchPriceFeed tests now. I looked more into the historical endpoint but the timestamps are a full day apart. I imagine the bots need more precision than this. Also, are there preferred ranges for lookback period and minTimeBetweenUpdates? Defi pulse only updates their api hourly.

chrismaree · 2021-01-21T09:26:07Z

packages/financial-templates-lib/src/price-feed/CreatePriceFeed.js

      config.decimals, // This defaults to 18 unless supplied by user
      config.ohlcPeriod // This defaults to 60 unless supplied by user
    );
-  } else if (config.type === "uniswap") {


why did you remove the existing uniswap feed? you should rather add your feed as another option rather than removing an existing feed that is used in production.

chrismaree · 2021-01-21T09:28:47Z

packages/financial-templates-lib/src/price-feed/DefiPulseTotalPriceFeed.js

+
+    }
+
+


this file still needs to be linted

chrismaree · 2021-01-21T09:29:08Z

packages/financial-templates-lib/test/price-feed/DefiPulseTotalPriceFeed.js

+      getTime,
+      minTimeBetweenUpdates
+    );
+


this file also needs to be linted.

chrismaree · 2021-01-21T09:29:35Z

packages/financial-templates-lib/test/price-feed/DefiPulseTotalPriceFeed.js

+
+  const apiKey = process.env.DEFIPULSE_API_KEY;
+
+  const lookback = 3600*24; //???????????????


what's up with this comment?

This was a note to myself that I was unclear about an appropriate lookback time. The API only changes at hourly intervals so the bots would run less frequently than others like cryptowatch.

bryanjcampbell1 · 2021-01-25T03:35:23Z

I made significant changes to the way the price feed the historical record. I am no longer building it by caching as I was able to get hourly values from the api. I am a little confused about the unit test though. How should I structure the fake data to inject? Also, how do I run the test? I tried calling 'truffle test' in root but just got a '0 passing' result.

chrismaree · 2021-01-25T13:04:22Z

I made significant changes to the way the price feed the historical record. I am no longer building it by caching as I was able to get hourly values from the api. I am a little confused about the unit test though. How should I structure the fake data to inject? Also, how do I run the test? I tried calling 'truffle test' in root but just got a '0 passing' result.

looks like you got the linter working, which is great!

To run your test file you should navigate to the financial-templates-lib directory then run:

yarn hardhat test ./test/price-feed/DefiPulseTotalPriceFeed.js

seeing you also changed the create price feed you should also test:

yarn hardhat test ./test/price-feed/createPriceFeed.js

I'll get your tests to run in CI now as well.

coveralls · 2021-01-25T13:48:08Z

Coverage remained the same at 93.261% when pulling 0d155b0 on bryanjcampbell1:master into 0b08724 on UMAprotocol:master.

bryanjcampbell1 · 2021-01-25T16:44:54Z

Got the unit tests working! Do I need to worry about the git signoff errors? Running "git rebase HEAD~11 --signoff" returns "unknown option `signoff'"

mrice32

Looks awesome -- a few minor comments, but I think this is just about ready!!

mrice32 · 2021-01-25T21:51:14Z

packages/financial-templates-lib/src/price-feed/DefiPulseTotalPriceFeed.js

+      }
+    }
+
+    const newPrice = this.web3.utils.toWei((mostRecent.tvlUSD / 1000000000).toFixed(6), "ether");


Can you provide a comment on what's happening here?

Also, do you think this should be a class function since you do the same operation in the getHistoricalPrice method?

mrice32 · 2021-01-25T21:55:37Z

packages/financial-templates-lib/src/price-feed/DefiPulseTotalPriceFeed.js

+      }
+    }
+
+    const historicalPrice = this.web3.utils.toWei((closestTime.tvlUSD / 1000000000).toFixed(6), "ether");


Does this respect the decimals value that is passed in the constructor?

I removed decimals from the constructor. The UMIP does specify 3 decimals of precision though so I made that change. What I want is that when tvlUSD = 24781234567, the token price to be $24.781 or 24781000000000000000 wei of the collateral token.

Am I understanding the price feed correctly? It should be returning a BN in wei correct?

chrismaree · 2021-01-26T10:05:42Z

packages/financial-templates-lib/src/price-feed/DefiPulseTotalPriceFeed.js

+      }
+    }
+
+    const historicalPrice = this.web3.utils.toWei((closestTime.tvlUSD / 1000000000).toFixed(3), "ether");


Seeing you do this computation two times (this.web3.utils.toWei((closestTime.tvlUSD / 1000000000).toFixed(3), "ether");) you could consider refactoring this into a helper method within this feed that is called in two places. This way you could add a more detailed comment around the umip definition and help with code re-use.

Also, you should consider adding this.toWei within the constructor, the same way you pulled out this.toBN on line 31. Then, you wont need to call this.web3.utils.toWei(... and can rather refer to this.toWei

chrismaree · 2021-01-26T10:08:32Z

Got the unit tests working! Do I need to worry about the git signoff errors? Running "git rebase HEAD~11 --signoff" returns "unknown option `signoff'"

you don't need to worry about the signoff part, we can set this from our side :)

Also looks like you need to lint again! normally we have a husky hook that should lint your code automatically whenever you commit. If you using something other than the console to commit it's possible this is not enabled.

I will re-run your tests through CI as well.

bryanjcampbell1 · 2021-01-28T18:54:24Z

What should my next steps be? I have run the cryptowatch bots on google cloud compute but I'm not sure how to configure to use my price feed.

mrice32 · 2021-02-01T05:54:44Z

@bryanjcampbell1 sorry that I'm just coming back to this PR. Side note/quick tip: once reviewers send a round of comments and you've responded and would like them to take another look, you can click the cycle button next to their names (see screenshot below) to request them again! This basically adds it back to each of our personal review queues so we see and come back to the PR. See our contributing guidelines for more info on our typical process: https://github.com/UMAprotocol/protocol/blob/master/CONTRIBUTING.md#prs.

I've gone ahead an re-requested myself and @chrismaree. Sorry for the delay!!

mrice32 · 2021-02-01T06:01:38Z

@bryanjcampbell1 @chrismaree Actually, you do need to signoff your commits. We need outside contributors to complete the DCO for legal reasons. It's how we show that you really agree to submit your code under the repo license and forgo your individual rights to the code.

chrismaree · 2021-02-01T11:36:41Z

packages/financial-templates-lib/src/price-feed/DefiPulseTotalPriceFeed.js

+    // Return early if the last call was too recent.
+    if (this.lastUpdateTime !== undefined && this.lastUpdateTime + this.minTimeBetweenUpdates > currentTime) {
+      this.logger.debug({
+        at: "DEFI_PULSE_TOTAL_TVL_PriceFeed",


nit: you should make this at the same as the file name. I know this feed was previous all upper case like this but that's no longer the case.

Suggested change

at: "DEFI_PULSE_TOTAL_TVL_PriceFeed",

at: "DefiPulseTotalPriceFeed",

chrismaree · 2021-02-01T11:36:52Z

packages/financial-templates-lib/src/price-feed/DefiPulseTotalPriceFeed.js

+    }
+
+    this.logger.debug({
+      at: "DEFI_PULSE_TOTAL_TVL_PriceFeed",


Suggested change

at: "DEFI_PULSE_TOTAL_TVL_PriceFeed",

at: "DefiPulseTotalPriceFeed",

chrismaree · 2021-02-01T11:38:18Z

yarn.lock

@@ -4677,6 +4677,15 @@
    "@uma/common" "^1.1.0"


not sure why there is a diff here?

chrismaree · 2021-02-01T11:54:22Z

packages/financial-templates-lib/src/price-feed/CreatePriceFeed.js

-      config.invertPrice // Not checked in config because this parameter just defaults to false.
+      config.invertPrice, // Not checked in config because this parameter just defaults to false.
+      config.poolDecimals,
+      config.priceFeedDecimals // This defaults to 18 unless supplied by user


why is this showing up as a diff? I'm pretty sure this is what the actual UniswapPriceFeed looks like.

My guess is that there are some merge issues, where these changes accidentally got removed in the merge process, but then were re-added in this branch to get the tests to pass.

chrismaree · 2021-02-01T11:59:16Z

This looks really good to me and super close to being done!

note that you still need to add in an additional set of changes in the DefaultPriceFeedConfigs file: https://github.com/UMAprotocol/protocol/blob/master/packages/financial-templates-lib/src/price-feed/DefaultPriceFeedConfigs.js

Also, what is the intended collateral for this synthetic? importantly, if it has non 18 decimals you will also need to add it to packages/common/src/PriceIdentifierUtils.js which can be found here: https://github.com/UMAprotocol/protocol/blob/master/packages/common/src/PriceIdentifierUtils.js

This ensures that the decimals in the price requests returned by the dvm is scalled according to the collateral type defined for the specific synthetic.

chrismaree · 2021-02-01T12:04:10Z

packages/financial-templates-lib/test/price-feed/DefiPulseTotalPriceFeed.js

+  let mockTime = 1611583300;
+  let networker;
+
+  const apiKey = process.env.DEFIPULSE_API_KEY;


unit tests should not rely on having this env set.

Changed to a test string

chrismaree · 2021-02-01T12:04:27Z

I just tried to run your tests and they failed as follows:

Ideally, the tests should be independent of an API key and solely rely on injected data from networker. An option could be to set it to something within the unit tests so you get past the assert(apiKey, "requires apiKey for Defi Pulse"); and then test with the mocked data from the networker.

mrice32 · 2021-02-02T02:18:45Z

@bryanjcampbell1 I updated the title to match the title in your description, just FYI!

mrice32 · 2021-02-02T02:35:19Z

@bryanjcampbell1 Responding to this comment above (posting here because the comment is way up there and now outdated because you've made some updates :)): #2346 (comment):

@chrismaree is a decimals input value required or is it okay for the price feed to always use the same decimals value? I assume the latter?
@smb2796 it appears as if UMIP-24 does not specify a collateral decimals value. Should we amend it to add one? @bryanjcampbell1 what collateral are y'all planning to use? (not necessary if you're planning to use a currency with 18 decimals).

mrice32

Looks awesome!

mrice32 · 2021-02-02T02:37:33Z

packages/financial-templates-lib/src/price-feed/DefiPulseTotalPriceFeed.js

+    // In an effort to make the token price affordable, the value of the token is the tvlUSD divided by 1 billion.
+    // We also cut off precision after 3 decimals to match the specified price step of .001
+
+    return this.toWei((_tvlUSD / 1000000000).toFixed(3), "ether");


nit for readability:

Suggested change

return this.toWei((_tvlUSD / 1000000000).toFixed(3), "ether");

const billion = 1_000_000_000;

return this.toWei((_tvlUSD / billion).toFixed(3), "ether");

Do most synths like this use USDC or TUSD? I had originally thought of using USDC (6 decimals).

Any tips for signing off on old commits? Just set up a GPG keypair. Should be good signing off from here on.

bryanjcampbell1 · 2021-02-02T23:12:36Z

What should I be using for my 'type' instead of 'medianizer'? I only have one source, the defipulse api, to get my value.

bryanjcampbell1 · 2021-02-09T20:59:58Z

Could you recommend a way for me to signoff on my old commits? I tried following this but ended up overwriting signatures from Sean, Matt, ect. Spent at least 2 hours on this lol.

Yep! Note: please back up your branch before you do this: git checkout -b backup_branch. Then switch back to the branch you've been using.

This is what I'd recommend as a simple way around these issues. Note: I'm using upstream/master as your local reference to our master branch. Just swap it out with whatever branch you typically merge into your branch to pull in upstream changes. Note: please make sure that whatever local reference you're using to refer to our master branch (upstream/master in the example below) has already been merged into your branch. If not, you'll get weird changes in the final diff.

git reset upstream/master -- this destroys the git history on your branch and makes it match upstream/master, BUT it keeps all your changes as unstaged changes.

git add . stages all of the changes at once.

git commit -s -m "feat(financial-templates): adds a new price feed for the DefiPulseTotalTVL synthetic tokens" creates a single signed commit on your branch that contains all of your changes.

git push -f force overwrites the remote branch on github.

Note: make sure you backup everything in a place where you can retrieve it if something breaks in this process. Since you're wiping your git history on your branch, you could wind up accidentally wiping your changes, so be sure you have a way to start over if things go bad!

Thanks! This was a huge help!

mrice32

This is great! I left a few suggestions to make price feed decimals match how it works in the other price feeds. Please take a look. I haven't tested the suggestions, but I think they should work. You'll probably need to re-lint the repo, though, because they probably aren't formatted correctly. You can do this by committing the suggestions, running git pull, then running yarn lint-fix from the root of the repo, and then committing and pushing any changes.

packages/financial-templates-lib/src/price-feed/DefiPulseTotalPriceFeed.js

packages/financial-templates-lib/test/price-feed/DefiPulseTotalPriceFeed.js

mrice32 · 2021-02-09T22:09:30Z

packages/financial-templates-lib/test/price-feed/DefiPulseTotalPriceFeed.js

+      networker,
+      getTime,
+      minTimeBetweenUpdates,
+      6 // Add arbitrary decimal conversion and prove this works.


Suggested change

6 // Add arbitrary decimal conversion and prove this works.

decimals // Add arbitrary decimal conversion and prove this works.

mrice32 · 2021-02-09T22:11:47Z

packages/financial-templates-lib/test/price-feed/DefiPulseTotalPriceFeed.js

+    assert.equal((await defiPulseTotalPriceFeed.getHistoricalPrice(1611575900)).toString(), web3.utils.toWei("24.78"));
+    assert.equal((await defiPulseTotalPriceFeed.getHistoricalPrice(1611579500)).toString(), web3.utils.toWei("23.50"));
+    assert.equal((await defiPulseTotalPriceFeed.getHistoricalPrice(1611579500)).toString(), web3.utils.toWei("23.50"));
+    assert.equal((await defiPulseTotalPriceFeed.getHistoricalPrice(1611579601)).toString(), web3.utils.toWei("22.25"));


Since the decimals are specified as 6, shouldn't these be coming out as 24.78 * 10^6? Right now, it looks like they're coming out as 24.78 * 10^18. See my comment above for how to make the price feed to do what you expect here.

Suggested change

assert.equal((await defiPulseTotalPriceFeed.getHistoricalPrice(1611575900)).toString(), web3.utils.toWei("24.78"));

assert.equal((await defiPulseTotalPriceFeed.getHistoricalPrice(1611579500)).toString(), web3.utils.toWei("23.50"));

assert.equal((await defiPulseTotalPriceFeed.getHistoricalPrice(1611579500)).toString(), web3.utils.toWei("23.50"));

assert.equal((await defiPulseTotalPriceFeed.getHistoricalPrice(1611579601)).toString(), web3.utils.toWei("22.25"));

assert.equal((await defiPulseTotalPriceFeed.getHistoricalPrice(1611575900)).toString(), parseFixed("24.78", decimals).toString());

assert.equal((await defiPulseTotalPriceFeed.getHistoricalPrice(1611579500)).toString(), parseFixed("23.50", decimals).toString());

assert.equal((await defiPulseTotalPriceFeed.getHistoricalPrice(1611579500)).toString(), parseFixed("23.50", decimals).toString());

assert.equal((await defiPulseTotalPriceFeed.getHistoricalPrice(1611579601)).toString(), parseFixed("22.25", decimals).toString());

mrice32 · 2021-02-09T22:12:18Z

packages/financial-templates-lib/test/price-feed/DefiPulseTotalPriceFeed.js

+    await defiPulseTotalPriceFeed.update();
+
+    // Should return the current price in the data.
+    assert.equal(defiPulseTotalPriceFeed.getCurrentPrice().toString(), web3.utils.toWei("25.1"));


Suggested change

assert.equal(defiPulseTotalPriceFeed.getCurrentPrice().toString(), web3.utils.toWei("25.1"));

assert.equal(defiPulseTotalPriceFeed.getCurrentPrice().toString(), parseFixed("25.1", decimals).toString());

bryanjcampbell1 · 2021-02-10T03:17:01Z

Accepted changes and ran through linter!

mrice32

I made a few small commits because I didn't realize you had manually made some of the changes I suggested -- then I had to undo them haha. But I think it looks good now!

LGTM assuming @chrismaree approves as well!

packages/financial-templates-lib/src/price-feed/DefiPulseTotalPriceFeed.js

chrismaree

This is so close to being ready. I have 2 nits and questions on some small spots.

Also, please add a test to validate non-18 decimals works as expected. Once this is done I think you good to go!

chrismaree · 2021-02-11T14:02:57Z

packages/financial-templates-lib/src/price-feed/CreatePriceFeed.js

+      networker,
+      getTime,
+      config.minTimeBetweenUpdates,
+      config.decimals


nit: for consistency please keep this as

Suggested change

config.decimals

config.priceFeedDecimals

chrismaree · 2021-02-11T14:03:45Z

packages/financial-templates-lib/test/price-feed/DefiPulseTotalPriceFeed.js

+    assert.equal(defiPulseTotalPriceFeed.getLastUpdateTime(), undefined);
+  });
+
+  it("Basic historical price", async function() {


ye, please add a test for this :)

…alTVL synthetic tokens Signed-off-by: bryanjcampbell1 <bryanjcampbell1@gmail.com>

bryanjcampbell1 · 2021-02-12T02:28:23Z

@chrismaree Matt helped me modify the test for "Basic historical price" so that it would work for arbitrary decimals. Please let me know if you are looking for something else!

Signed-off-by: bryanjcampbell1 <bryanjcampbell1@gmail.com>

chrismaree

Thanks for replying to all the changes and updating your PR accordingly! this is pretty awesome, I'm looking forward to seeing this on main net 🚀

chrismaree · 2021-02-12T07:12:56Z

I'm running your test in CI again.

nicholaspai · 2021-02-12T17:24:59Z

packages/financial-templates-lib/src/price-feed/CreatePriceFeed.js

+  } else if (config.type === "defipulsetvl") {
+    const requiredFields = ["lookback", "minTimeBetweenUpdates"];
+
+    if (isMissingField(config, config.apiKey, requiredFields, logger)) {


Why don't you add the apiKey to requiredFields?

nicholaspai · 2021-02-12T17:26:01Z

packages/financial-templates-lib/src/price-feed/DefiPulseTotalPriceFeed.js

+
+  async getHistoricalPrice(time) {
+    if (this.lastUpdateTime === undefined) {
+      throw new Error(`${this.uuid}: undefined lastUpdateTime`);


I don't see that you've defined this.uuid in the constructor

nicholaspai · 2021-02-12T17:26:40Z

packages/financial-templates-lib/src/price-feed/DefiPulseTotalPriceFeed.js

+    this.web3 = web3;
+
+    this.apiKey = apiKey;
+    assert(apiKey, "requires apiKey for Defi Pulse");


Instead of asserting it here, I recommend adding apiKey to the requiredFields array in CreatePriceFeed

nicholaspai

I left some comments that once resolved are good to merge

Signed-off-by: bryanjcampbell1 <bryanjcampbell1@gmail.com>

Merge branch 'master' of https://github.com/bryanjcampbell1/protocol into bryanjcampbell1/master

nicholaspai · 2021-02-16T18:25:21Z

packages/financial-templates-lib/src/price-feed/DefiPulseTotalPriceFeed.js

+
+  async getHistoricalPrice(time) {
+    if (this.lastUpdateTime === undefined) {
+      throw new Error("undefined lastUpdateTime");


Can you follow this this.uuid pattern and add a uuid class param that makes the Error slightly more descriptive please? Sorry and thanks!

daywiss · 2021-02-17T18:19:24Z

@bryanjcampbell1 looks like there is just one outstanding issue and this can go in!

Signed-off-by: Nick Pai <npai.nyc@gmail.com>

chrismaree reviewed Dec 28, 2020

View reviewed changes

mrice32 reviewed Jan 5, 2021

View reviewed changes

smb2796 requested review from chrismaree and mrice32 January 20, 2021 19:12

chrismaree reviewed Jan 21, 2021

View reviewed changes

mrice32 reviewed Jan 25, 2021

View reviewed changes

chrismaree reviewed Jan 26, 2021

View reviewed changes

mrice32 requested review from chrismaree and mrice32 February 1, 2021 05:55

chrismaree reviewed Feb 1, 2021

View reviewed changes

yarn.lock

@@ -4677,6 +4677,15 @@

"@uma/common" "^1.1.0"

Copy link
Copy Markdown

Member

chrismaree Feb 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why there is a diff here?

chrismaree reviewed Feb 1, 2021

View reviewed changes

mrice32 changed the title ~~Added DEFI_PULSE_TOTAL_TVL price feed~~ feat(financial-templates): adds a new price feed for the DefiPulseTotalTVL synthetic tokens Feb 2, 2021

mrice32 reviewed Feb 2, 2021

View reviewed changes

bryanjcampbell1 requested a review from mrice32 February 2, 2021 23:13

bryanjcampbell1 requested a review from mrice32 February 9, 2021 20:59

mrice32 reviewed Feb 9, 2021

View reviewed changes

bryanjcampbell1 requested a review from mrice32 February 10, 2021 03:17

mrice32 approved these changes Feb 10, 2021

View reviewed changes

nicholaspai mentioned this pull request Feb 11, 2021

feat(default-price-feed): add TraderMadePriceFeed #2479

Merged

chrismaree reviewed Feb 11, 2021

View reviewed changes

packages/financial-templates-lib/src/price-feed/DefiPulseTotalPriceFeed.js Show resolved Hide resolved

chrismaree reviewed Feb 11, 2021

View reviewed changes

packages/financial-templates-lib/src/price-feed/DefiPulseTotalPriceFeed.js Show resolved Hide resolved

chrismaree reviewed Feb 11, 2021

View reviewed changes

feat(financial-templates): adds a new price feed for the DefiPulseTot…

4ed7bee

…alTVL synthetic tokens Signed-off-by: bryanjcampbell1 <bryanjcampbell1@gmail.com>

fixed error caught by linter

47e635f

Signed-off-by: bryanjcampbell1 <bryanjcampbell1@gmail.com>

bryanjcampbell1 requested a review from chrismaree February 12, 2021 02:34

chrismaree approved these changes Feb 12, 2021

View reviewed changes

Merge branch 'master' into master

4cc4b7e

nicholaspai reviewed Feb 12, 2021

View reviewed changes

nicholaspai approved these changes Feb 12, 2021

View reviewed changes

bryanjcampbell1 added 2 commits February 12, 2021 15:57

removed assert in favor of setting api key to be a required field

ecb3e0f

Signed-off-by: bryanjcampbell1 <bryanjcampbell1@gmail.com>

merge with remote

1a1999e

Merge branch 'master' of https://github.com/bryanjcampbell1/protocol into bryanjcampbell1/master

bryanjcampbell1 requested a review from nicholaspai February 12, 2021 21:13

nicholaspai reviewed Feb 16, 2021

View reviewed changes

nicholaspai and others added 2 commits February 18, 2021 16:25

Merge branch 'master' into master

1e3a0b1

add uuid

ec0b94b

Signed-off-by: Nick Pai <npai.nyc@gmail.com>

nicholaspai merged commit 71a6cfb into UMAprotocol:master Feb 19, 2021

chrismaree mentioned this pull request May 26, 2021

improve(financial-templates-lib): Update OCEANUSD default price confi… #3010

Merged

5 tasks


		let closestTime = {timestamp:0, value:0};

		//go through all values and find time that that is the largest and still less than 'time'


		const apiKey = process.env.DEFIPULSE_API_KEY;

		const lookback = 3600*24; //???????????????

	at: "DEFI_PULSE_TOTAL_TVL_PriceFeed",
	at: "DefiPulseTotalPriceFeed",

	return this.toWei((_tvlUSD / 1000000000).toFixed(3), "ether");
	const billion = 1_000_000_000;
	return this.toWei((_tvlUSD / billion).toFixed(3), "ether");

	6 // Add arbitrary decimal conversion and prove this works.
	decimals // Add arbitrary decimal conversion and prove this works.

	assert.equal(defiPulseTotalPriceFeed.getCurrentPrice().toString(), web3.utils.toWei("25.1"));
	assert.equal(defiPulseTotalPriceFeed.getCurrentPrice().toString(), parseFixed("25.1", decimals).toString());

Conversation

bryanjcampbell1 commented Dec 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrismaree left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrice32 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bryanjcampbell1 commented Jan 25, 2021

Uh oh!

chrismaree commented Jan 25, 2021

Uh oh!

coveralls commented Jan 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bryanjcampbell1 commented Jan 25, 2021

Uh oh!

mrice32 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chrismaree commented Jan 26, 2021

Uh oh!

bryanjcampbell1 commented Jan 28, 2021

Uh oh!

mrice32 commented Feb 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrice32 commented Feb 1, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

bryanjcampbell1 commented Dec 23, 2020 •

edited

Loading

coveralls commented Jan 25, 2021 •

edited

Loading

mrice32 commented Feb 1, 2021 •

edited

Loading