feat(ui5-*): integrate element internals in input components#8685
Merged
feat(ui5-*): integrate element internals in input components#8685
Conversation
added 15 commits
April 8, 2024 15:19
nnaydenow
commented
May 9, 2024
ilhan007
reviewed
May 9, 2024
ilhan007
reviewed
May 9, 2024
ilhan007
reviewed
May 9, 2024
Contributor
ilhan007
left a comment
There was a problem hiding this comment.
Overall, looks good to me.
We have to only commonly agree on the updatesFormValue new metadata entity name.
Contributor
Author
As discussed offline the metadata name is changed to formValue |
pskelin
requested changes
May 10, 2024
ilhan007
approved these changes
May 13, 2024
pskelin
approved these changes
May 14, 2024
This was referenced May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate the ElementInternals feature into UI5 web components. This enhancement allows input-like web components to behave as native input elements within HTML forms. As a result, the
features/InputElementsFormSupport.jsfeature is now redundant and has been removed.Changes in
@customElementdecorator: Added newformAssociatedflag attaches internals to the component when the component is associated with form (placed inside form).BREAKING CHANGE: The
features/InputElementsFormSupport.jsfeature has been deleted and now, form elements works natively in form elements.Related: #8461