fix(ui5-popup): handle multiple _open calls#8647
Merged
dimovpetar merged 1 commit intorelease-2.0from Apr 4, 2024
Merged
Conversation
nnaydenow
reviewed
Apr 4, 2024
Contributor
nnaydenow
left a comment
There was a problem hiding this comment.
I though that we are switching to declarative opening of popup at all and we are removing these showAt / openBy... methods. Do we plan to leave these methods ?
d9701a2 to
60d0b66
Compare
Member
Author
I am not aware of these plans. If we do it, then I guess this code can be deleted carefully. Until then we need it to prevent never closing popover in the TabContainer. |
vladitasev
approved these changes
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.