Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed the type of
labelfield inStrand,Domain,Loopout, andExtensiontostrinstead of an arbitrary object.Related Issue
#261
Motivation and Context
Supporting arbitrary data is more complex, both for the type checking (requiring some ugly
Genericdeclarations), and for trying to serialize and deserialize automatically. Instead users can serialize and deserialize manually using thejsonpackage:How Has This Been Tested?
Mostly just changed type hints, so checked that there are no mypy errors.
Screenshots (if appropriate):