Set Position3D as frozen#233
Merged
dave-doty merged 1 commit intoUC-Davis-molecular-computing:devfrom Jul 21, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mutable defaults in dataclasses will cause an error in Python 3.11. HelixGroup has a Position3D default. Position3D appears to be intended to be immutable, and is never used mutably in the code, but does not have
frozen=Trueset for the dataclass options. This sets it, and causes tests to pass with Python 3.11.0b4.Alternatively, Position3D could be left as is, and the HelixGroup position could be made to be
position: Position3D = field(default_factory=lambda: Position3D(x=0,y=0,z=0)), but this seems less efficient.