Helix order when importing from cadnano#217
Merged
Conversation
dave-doty
approved these changes
Feb 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cadnano's helix order was not conserved when using
from_cadnano_v2. That happened because @dave-doty thought that the constructor ofDesignwould automatically handle this ordering (by correctly settinghelices_view_order) but it does not. I have given more details in the related issue: #202In order to fix this bug I uncommented the following instruction which sets the helix order directly in the import code instead of relying on Design's constructor:
design.set_helices_view_order([num for num in helices])l.4648Related Issue
#202
How Has This Been Tested?
I added the test
tests.scadnano_tests.TestImportCadnanoV2.test_helices_order2