Merged
Conversation
dave-doty
approved these changes
Oct 17, 2021
Member
There was a problem hiding this comment.
Looks good.
We talked about a way to have this automatically populate the PR description field. It says that this will happen, but I'm not sure how since the only change is to add this .md file. Is it based on filename convention? (similar to how README.md is the file automatically displayed on the GitHub page)
Collaborator
Author
|
Yup it’s automatic. Here’s a reference:
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository
…On Sun, Oct 17, 2021 at 9:44 AM David Doty ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good.
We talked about a way to have this automatically populate the PR
description field. It says that this will happen, but I'm not sure how
since the only change is to add this .md file. Is it based on convention?
(similar to how README.md is the file automatically displayed on the GitHub
page)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#195 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHOOY77QIJBDG53LRZI7IYLUHL4MVANCNFSM5GEI3BWQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a simple PR template. (Inspired by https://github.com/stevemao/github-issue-templates/blob/master/bugs-only/PULL_REQUEST_TEMPLATE.md)
Motivation and Context
Improve the code review process by providing a template for PR descriptions.
How Has This Been Tested?
Manually tested on my fork: UnHumbleBen/scadnano-python-package-1@master...UnHumbleBen:dev
Verified the template is automatically pasted into the pull request body
Screenshots (if appropriate):