Skip to content

Bug fix helix number was badly set in cadnano export#189

Merged
tcosmo merged 6 commits intodevfrom
bug_paranemic_crossovers
Aug 3, 2021
Merged

Bug fix helix number was badly set in cadnano export#189
tcosmo merged 6 commits intodevfrom
bug_paranemic_crossovers

Conversation

@tcosmo
Copy link
Copy Markdown
Collaborator

@tcosmo tcosmo commented Aug 2, 2021

@tcosmo tcosmo requested a review from dave-doty as a code owner August 2, 2021 13:53
Copy link
Copy Markdown
Member

@dave-doty dave-doty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the unit tests are failing.

@tcosmo
Copy link
Copy Markdown
Collaborator Author

tcosmo commented Aug 3, 2021

@dave-doty it is fixed, it came from the messy situation that tests_inputs/cadnano_v2_export/ are gitignored because most of them are automatically generated but in the paranemic case, the test is not generated but to be read from a .sc file so it was failing because the file was not found.

@tcosmo
Copy link
Copy Markdown
Collaborator Author

tcosmo commented Aug 3, 2021

@dave-doty I mistakenly did the pull request to main, should I move it to dev?

Also note that the tests for the import/export features are quite weak as they do not check, for example in the case of exporting to cadnano, that cadnano can actually read the file.

It results for instance in test 'TestExportCadnanoV2.test_export_design_with_helix_group' creating a file that cadnano cannot process.

@dave-doty
Copy link
Copy Markdown
Member

@dave-doty I mistakenly did the pull request to main, should I move it to dev?

Good catch, yes please merge to dev instead of main.

@tcosmo tcosmo changed the base branch from main to dev August 3, 2021 15:11
@tcosmo tcosmo merged commit b73d152 into dev Aug 3, 2021
@tcosmo tcosmo deleted the bug_paranemic_crossovers branch August 3, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants