automatically install dataclass backport for Python 3.6#135
Conversation
| long_description_content_type='text/markdown; variant=GFM', | ||
| requires=['xlwt'] | ||
| ) | ||
| requires=['xlwt'], |
There was a problem hiding this comment.
I just want to make absolutely sure that this will still allow the package to be installed on Python 3.7 or higher. The syntax looks like it's saying that we require Python 3.6 or below.
But is this just saying that, if the Python version is 3.6 or below, then install dataclasses?
There was a problem hiding this comment.
Yes I tested it. Simple way to test it create two virtual env, one under python 3.6 and one under python 3.7 and theninside each venv, run "python setup.py", the installation is successful in both cases.
There was a problem hiding this comment.
And, in the venv with python 3.6, the dataclass package is present and importable after running the script.
There was a problem hiding this comment.
The syntax is indeed saying, care about the previous package iff this condition on python version is met
|
@dave-doty added instruction to force min python version to be 3.6: |
Tested and Solved with 1102804