Conversation
incorrectly bumped version last time; bumping it in _version.py now
…ix_bundle_honeycomb restored.
…ix_bundle_honeycomb restored.
…ix_bundle_honeycomb restored.
…ix_bundle_honeycomb restored.
|
Designs with helix groups sharing same grid are now exportable. Also working on cadnano oligos names not done yet. |
scadnano/scadnano.py
Outdated
| domain, next_domain, strand_type) | ||
|
|
||
| def _cadnano_v2_fill_blank(self, dct: dict, num_bases: int) -> Dict[int, int]: | ||
| def _cadnano_v2_fill_blank(self, dct: dict, num_bases: int, design_grid: Grid) -> dict: |
There was a problem hiding this comment.
Did I get the type wrong here? I had annotated the return type of _cadnano_v2_fill_blank as Dict[int, int] based on looking at usages in the definition.
If that's wrong, can we specify a more specific type than dict? Or do the types of the the values and keys vary?
If only the values vary, but the keys are always int, then it's still better to use Dict[int, Any] (instead of dict)
dave-doty
left a comment
There was a problem hiding this comment.
I approved the PR, but then noticed that unit tests are not passing. Looking at the logs, I think there is a syntax error somewhere. Can you run the unit tests locally and see where the problem is?
|
@dave-doty my very bad, solved with 627d45b |
No description provided.