Conversation
stweil
reviewed
Dec 11, 2017
| @@ -1,4 +1,6 @@ | |||
| /* globals $ */ | |||
| /* globals Blob */ | |||
| /* global Prism */ | |||
Member
There was a problem hiding this comment.
Is there a difference between globals (as in line 2) and global (as in line 3) here?
stweil
approved these changes
Dec 11, 2017
Member
There was a problem hiding this comment.
Thank you, @kba. The new code works fine (installed and tested on https://digi.bib.uni-mannheim.de/ocr-fileformat).
zuphilip
reviewed
Dec 11, 2017
| && update-ca-certificates \ | ||
| && make install \ | ||
| && cp docker.config.php web/config.local.php \ | ||
| && sed -i '/^upload_max_filesize/ s/=.*$/= 100M' \ |
Member
There was a problem hiding this comment.
There seems to be a problem with the automated Docker build on docker hub: https://hub.docker.com/r/ubma/ocr-fileformat/builds/bvafgbah9zqysoblyvupmeg/
Collaborator
Author
There was a problem hiding this comment.
Fixed. Since the image sizes don't differ now, I'll sumit my dev Dockerfile later.
Member
|
I have committed a fix for |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data-URL technique only works for reasonably short strings, this is a more robust implementation. Should work for transformations from URL and upload.