Skip to content

Move navbar above tab panes in web interface#72

Merged
kba merged 1 commit intoUB-Mannheim:masterfrom
zuphilip:navbar-top
Dec 11, 2017
Merged

Move navbar above tab panes in web interface#72
kba merged 1 commit intoUB-Mannheim:masterfrom
zuphilip:navbar-top

Conversation

@zuphilip
Copy link
Copy Markdown
Member

@zuphilip zuphilip commented Dec 11, 2017

Previous:

navbar-now

With this PR:

navbar-move

@stweil
Copy link
Copy Markdown
Member

stweil commented Dec 11, 2017

While improving the look-and-feel: displaying the release tag might also be a good idea. Maybe at the right side of the black bar?

@zuphilip
Copy link
Copy Markdown
Member Author

Agree on this idea. But I am not skilled enough to read the info automatically into this html. Any help?

@zuphilip
Copy link
Copy Markdown
Member Author

Or maybe just postpone it as an issue?

@kba
Copy link
Copy Markdown
Collaborator

kba commented Dec 11, 2017

Getting revision info into the web assets would require a build step or reliance on convention or installation. Not hard but finicky and nothing to do with this PR IIUC.

I liked the tabs as they were, but not enough to oppose this :)

@kba kba merged commit f3ea365 into UB-Mannheim:master Dec 11, 2017
@zuphilip zuphilip deleted the navbar-top branch December 11, 2017 12:50
@zuphilip
Copy link
Copy Markdown
Member Author

( I prefer to click from top-to-bottom and left-to-right :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants