Skip to content

install page2img#189

Merged
stweil merged 2 commits intoUB-Mannheim:masterfrom
bertsky:page2img
Apr 30, 2025
Merged

install page2img#189
stweil merged 2 commits intoUB-Mannheim:masterfrom
bertsky:page2img

Conversation

@bertsky
Copy link
Copy Markdown
Contributor

@bertsky bertsky commented Apr 28, 2025

@stweil stweil marked this pull request as draft April 29, 2025 12:30
@stweil
Copy link
Copy Markdown
Member

stweil commented Apr 29, 2025

Merging this PR would currently break the installation. Therefore this is marked as a draft PR until the mentioned dependency is available.

Copy link
Copy Markdown
Member

@stweil stweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kba also suggested a different name for the new Python module. The same name must be used here, too,

@kba
Copy link
Copy Markdown
Collaborator

kba commented Apr 30, 2025

Merging this PR would currently break the installation. Therefore this is marked as a draft PR until the mentioned dependency is available.

OCR-D/format-converters#28 has been merged and published https://pypi.org/project/ocrd-format-converters/

@kba also suggested a different name for the new Python module. The same name must be used here, too,

Not really, since we're not installing from PyPI but from the submodule, which can remain called format-converters. The rename is just for the PyPI release to avoid confusion with a similarly named old project there.

@kba kba marked this pull request as ready for review April 30, 2025 13:11
Copy link
Copy Markdown
Member

@stweil stweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@stweil stweil merged commit 3540a3b into UB-Mannheim:master Apr 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants