Skip to content

gcv__page: use -source-json instead of -source-xml#156

Merged
stweil merged 1 commit intoUB-Mannheim:masterfrom
bertsky:fix-gcv-page-converter
Nov 25, 2022
Merged

gcv__page: use -source-json instead of -source-xml#156
stweil merged 1 commit intoUB-Mannheim:masterfrom
bertsky:fix-gcv-page-converter

Conversation

@bertsky
Copy link
Copy Markdown
Contributor

@bertsky bertsky commented Nov 17, 2022

No description provided.

Copy link
Copy Markdown
Member

@stweil stweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@stweil
Copy link
Copy Markdown
Member

stweil commented Nov 17, 2022

I'd like to run a test before merging and ideally there should also be a unit test. Can we get a (small) GCV file for such tests?

@stweil stweil merged commit 85c6325 into UB-Mannheim:master Nov 25, 2022
@stweil
Copy link
Copy Markdown
Member

stweil commented Nov 25, 2022

A test is still missing. I decided to pull the commit nevertheless because I expect that it improves the situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants