vendor/Makefile: page-to-alto is phony#154
Merged
stweil merged 1 commit intoUB-Mannheim:masterfrom Nov 8, 2022
Merged
Conversation
kba
approved these changes
Nov 7, 2022
stweil
reviewed
Nov 7, 2022
Member
stweil
left a comment
There was a problem hiding this comment.
I am not sure that this is the right fix (even if it seems to fix the problem). gcv2hocr is missing, too. And I also did not find a regression. Did the installation ever work before? If yes, with which version?
stweil
requested changes
Nov 8, 2022
| #}}} | ||
|
|
||
| .PHONY: all check $(PAGE_SCHEMA_REPO) $(ABBYY_SCHEMA_REPO) | ||
| .PHONY: all check $(PAGE_SCHEMA_REPO) $(ABBYY_SCHEMA_REPO) page-to-alto |
Member
There was a problem hiding this comment.
Suggested change
| .PHONY: all check $(PAGE_SCHEMA_REPO) $(ABBYY_SCHEMA_REPO) page-to-alto | |
| .PHONY: all check $(PAGE_SCHEMA_REPO) $(ABBYY_SCHEMA_REPO) page-to-alto gcv2hocr |
Member
|
In the old code the installation of The suggested pull request restores the old behaviour partially. With my addition, it also restores |
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #153