Skip to content

assertScriptCanLoadAsCJS() can trigger self when loading assertScriptCanLoadAsCJSImpl #1235

@cspotcode

Description

@cspotcode

assertScriptCanLoadAsCJS() loads assertScriptCanLoadAsCJSImpl() on-demand.

It seems that with allowJs / checkJs enabled, our own loader hook is called during the loading process. This causes an error where assertScriptCanLoadAsCJSImpl is invoked before it's loaded.

Also, I need to be sure I understand why our tests weren't catching this before. Is it possible that the "ignore" rules have broken? Or is it that the test cases which uncovered this bug are explicitly disabling "ignore" patterns?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions