Skip to content

fix: cater for change in resolveTypeReferenceDirective API in 4.7#1446

Merged
johnnyreilly merged 6 commits into
TypeStrong:webpack-4from
dragomirtitian:webpack-4-resolveTypeReferences
Apr 26, 2022
Merged

fix: cater for change in resolveTypeReferenceDirective API in 4.7#1446
johnnyreilly merged 6 commits into
TypeStrong:webpack-4from
dragomirtitian:webpack-4-resolveTypeReferences

Conversation

@dragomirtitian

Copy link
Copy Markdown

fix: cater for change in resolveTypeReferenceDirective API in TypeScript 4.7

@dragomirtitian

Copy link
Copy Markdown
Author

@johnnyreilly I cherry picked your commit and made small changes. The tests seem to work locally. Don't think I can run the CI myself. Let me know if there is anything else I should do.

@johnnyreilly

Copy link
Copy Markdown
Member

Thanks chap - I've kicked off the build and will keep an eye on it!

@johnnyreilly johnnyreilly left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@johnnyreilly johnnyreilly merged commit ef85a62 into TypeStrong:webpack-4 Apr 26, 2022
@johnnyreilly

Copy link
Copy Markdown
Member

Hopefully this should ship in the next 20 mins or so: https://github.com/TypeStrong/ts-loader/releases/tag/v8.4.0

@johnnyreilly

Copy link
Copy Markdown
Member

Live! Thanks for your help @dragomirtitian ❤️ 🌻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants