Skip to content

9.6.0 breaks rspack compatibility #1698

Description

@bhollis

ts-loader 9.6.0 fails under rspack with the following error:

[rspack-cli] [Error:   × caused by plugins in Compilation.hooks.processAssets
  ╰─▶   × TypeError: module.getWarnings is not a function
        │     at removeModuleTSLoaderError (/Users/brh/Documents/oss/DIM/node_modules/.pnpm/ts-loader@9.6.0_loader-utils@3.3.1_typescript@6.0.3_webpack@5.107.2_postcss@8.5.15_/node_modules/ts-loader/dist/after-compile.js:312:44)
        │     at /Users/brh/Documents/oss/DIM/node_modules/.pnpm/ts-loader@9.6.0_loader-utils@3.3.1_typescript@6.0.3_webpack@5.107.2_postcss@8.5.15_/node_modules/ts-loader/dist/after-compile.js:186:17
        │     at Array.forEach (<anonymous>)
        │     at provideErrorsToWebpack (/Users/brh/Documents/oss/DIM/node_modules/.pnpm/ts-loader@9.6.0_loader-utils@3.3.1_typescript@6.0.3_webpack@5.107.2_postcss@8.5.15_/node_modules/ts-loader/dist/after-compile.js:185:31)
        │     at /Users/brh/Documents/oss/DIM/node_modules/.pnpm/ts-loader@9.6.0_loader-utils@3.3.1_typescript@6.0.3_webpack@5.107.2_postcss@8.5.15_/node_modules/ts-loader/dist/after-compile.js:70:9
        │     at Object.fn (/Users/brh/Documents/oss/DIM/node_modules/.pnpm/ts-loader@9.6.0_loader-utils@3.3.1_typescript@6.0.3_webpack@5.107.2_postcss@8.5.15_/node_modules/ts-loader/dist/instances.js:252:17)
        │     at next (file:///Users/brh/Documents/oss/DIM/node_modules/.pnpm/@rspack+core@2.0.8_@swc+helpers@0.5.23/node_modules/@rspack/core/dist/index.js:641:25)
        │     at file:///Users/brh/Documents/oss/DIM/node_modules/.pnpm/@rspack+core@2.0.8_@swc+helpers@0.5.23/node_modules/@rspack/core/dist/index.js:636:109
        │     at /Users/brh/Documents/oss/DIM/node_modules/.pnpm/html-webpack-plugin@5.6.7_@rspack+core@2.0.8_@swc+helpers@0.5.23__webpack@5.107.2_postcss@8.5.15_/node_modules/html-webpack-plugin/lib/cached-child-compiler.js:351:53

The issue is that removeModuleTSLoaderError unconditionally accesses getWarnings which doesn't exist in rspack's implementation of module. Rolling back to 9.5.4 works fine.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions