chore(deps): update chokidar, constrain engines#852
Closed
Fuzzyma wants to merge 1 commit intoTypeStrong:mainfrom
Closed
chore(deps): update chokidar, constrain engines#852Fuzzyma wants to merge 1 commit intoTypeStrong:mainfrom
Fuzzyma wants to merge 1 commit intoTypeStrong:mainfrom
Conversation
Author
|
The CI fails because it cant install typescript because it tries to get the package from a url ending in ":". No idea where this is coming from tbh :D |
Collaborator
|
Looks like we have broken E2E tests: I will take a look at them later (I'm pretty busy these days, it might take a while) |
Collaborator
Author
|
Awesome. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates chokidar to v4 and reduces its dependency count to 1.
It also constrains the engine field in package.json to use node versions that are supported by the tests.
Unfortunately there is not a way to only constrain it for development (since I am sure this package also runs in newer node versions once bundled). So if you want me to remove the constraint let me know.
In that case I would add a note in the readme