Skip to content

fix: getPos race condition in React StrictMode #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nperez0111 merged 3 commits into from
Jan 8, 2026
Merged

fix: getPos race condition in React StrictMode #2311

nperez0111 merged 3 commits into from
Jan 8, 2026

Conversation

@YousefED
Copy link
Collaborator

@YousefED YousefED commented Dec 22, 2025

Summary

This adds a test that can reproduce the issue described here: #2106

I've also diagnosed the issue and added an upstream fix: ueberdosis/tiptap#7362

Rationale

x

Changes

  • added test
  • update tiptap to fix issue

Impact

x

Testing

unit test added, and tested manually

Screenshots/Video

x

Checklist

  • Code follows the project's coding standards.
  • Unit tests covering the new feature have been added.
  • All existing tests pass.
  • The documentation has been updated to reflect the new feature

Additional Notes

x

@vercel
Copy link

vercel bot commented Dec 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
blocknote Ready Ready Preview Jan 8, 2026 10:37am
blocknote-agent-demo Error Error Jan 8, 2026 10:37am
blocknote-website Error Error Jan 8, 2026 10:37am

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 8, 2026

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/ariakit@2311

@blocknote/code-block

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/code-block@2311

@blocknote/core

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/core@2311

@blocknote/mantine

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/mantine@2311

@blocknote/react

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/react@2311

@blocknote/server-util

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/server-util@2311

@blocknote/shadcn

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/shadcn@2311

@blocknote/xl-ai

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-ai@2311

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-docx-exporter@2311

@blocknote/xl-email-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-email-exporter@2311

@blocknote/xl-multi-column

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-multi-column@2311

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-odt-exporter@2311

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-pdf-exporter@2311

commit: 1103c9a

@nperez0111 nperez0111 marked this pull request as ready for review January 8, 2026 10:41
@nperez0111 nperez0111 merged commit 410db8b into main Jan 8, 2026
7 of 8 checks passed
@nperez0111 nperez0111 deleted the fix/react-strictmode-getpos branch January 8, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YousefED @nperez0111