Merged
Conversation
Contributor
|
|
Contributor
|
Don't understand why it doesn't download the flatpak artifact |
Collaborator
Author
I try to redo this by going back to the actions/download-artifact@v3 |
Collaborator
Author
|
Ja, this is a problem with v4, but v3 works |
Contributor
|
Ah yes it worked! Strange that the version matters here Breaking Changes For assistance with breaking changes, see MIGRATION.md. So as conclusion. The upload-artifact must stick to version 3 until |
Collaborator
Author
|
I'm going to fix it. |
Murmele
reviewed
Feb 19, 2024
Co-authored-by: Murmele <Murmele@users.noreply.github.com>
Collaborator
|
@Murmele please take a look when you are able to, thank you! |
Contributor
|
@bitcraft looks good to me. @JaskRendix Thanks for fixing! |
bitcraft
approved these changes
Mar 17, 2024
bitcraft
approved these changes
Mar 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR fixes the publishing action by going back to the version 3, at least until
flatpak-github-actions/flatpak-builderupdates to v4thanks @Murmele I didn't know about the verbose: true