Clean up isobands output for empty bands#2957
Merged
Conversation
- Bands that are above the highest data in the grid will no longer incorrectly emit a polygon that contains the entire grid Fixes #2956
Collaborator
Author
|
cc @smallsaucepan and @l-sola |
|
Tested and working! Thanks for the quick solution @mfedderly |
smallsaucepan
approved these changes
Nov 22, 2025
Member
|
Thanks @mfedderly and @l-sola 👍 |
|
Hi, I just upgraded turf from 7.2.0 to 7.3.0 and found that the isobands function can not work. Is this fix worth a patch release (7.3.1) to prevent further developers from getting stuck on this issue? |
Member
|
Hi @plainheart Subscribe to #2962 to keep up to date on the next release (should be out soon). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bands that are above the highest data in the grid will no longer incorrectly emit a polygon that contains the entire grid. This was a regression from the changes in #2926. This reverts the broken behavior and instead omits a Feature with the properties entry for the band, but then a MultiPolygon geometry with a coordinates value of exactly
[].Fixes #2956