Skip to content

turf-hexgrid: fix issue #2841#2856

Merged
twelch merged 2 commits intoTurfjs:masterfrom
SimonsUnikaNamn:fix/turf-hexgrid-typing
Mar 17, 2025
Merged

turf-hexgrid: fix issue #2841#2856
twelch merged 2 commits intoTurfjs:masterfrom
SimonsUnikaNamn:fix/turf-hexgrid-typing

Conversation

@SimonsUnikaNamn
Copy link
Copy Markdown
Contributor

Summary of changes:
Allowed mask to be of type Polygon | MultiPolygon
Typing of mask does not allow for MultiPolygon while the documentation obviously states that this is allowed

I have read the preparing a pull request section. One unrelated test failed. so I hope my local setup is incorrect and the CI will let this pass

Typing of mask does not allow for MultiPolygon while the documentation obviously states that this is allowed
Copy link
Copy Markdown
Collaborator

@twelch twelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good @SimonsUnikaNamn, tests are passing. I'm not seeing any calls within that need to be changed to accept Multipolygon too.

@twelch twelch merged commit 212d166 into Turfjs:master Mar 17, 2025
3 checks passed
@twelch
Copy link
Copy Markdown
Collaborator

twelch commented Mar 17, 2025

Thanks for your contribution. This will become available in the next release

@SimonsUnikaNamn SimonsUnikaNamn deleted the fix/turf-hexgrid-typing branch March 17, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants