Fix - Documented unit used for Earth's radius#2842
Merged
smallsaucepan merged 1 commit intoTurfjs:masterfrom Feb 18, 2025
IvoBiaus:earth-radius
Merged
Fix - Documented unit used for Earth's radius#2842smallsaucepan merged 1 commit intoTurfjs:masterfrom IvoBiaus:earth-radius
smallsaucepan merged 1 commit intoTurfjs:masterfrom
IvoBiaus:earth-radius
Conversation
smallsaucepan
approved these changes
Feb 18, 2025
Member
|
Thanks for fixing this @IvoBiaus 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected the "unit" that is documented as the one being used for the Earth's radius, from "kilometers" to "meters".
The constant value is:
6371008.8, which is + 6 million, that would be meters.As mentioned in the Wikipedia that is referenced in the documentation https://en.wikipedia.org/wiki/Earth_radius#Arithmetic_mean_radius
6371 km are 6.371.000 meters.
This change should not bring any errors, since only changes the documentation, instead of changing the constant value to kilometers.
I took a quick look, and the code seems to have been done using the correct "meters" unit, for example when checking out the factors constant: