Fixed simplify to not get stuck in an infinite loop on certain geometries#2830
Merged
smallsaucepan merged 2 commits intoTurfjs:masterfrom May 15, 2025
Merged
Conversation
…uce the tolerance far enough to generate a valid polygon. Tidied up docs.
mfedderly
approved these changes
May 12, 2025
| ## nearestNeighborAnalysis | ||
|
|
||
| Nearest Neighbor Analysis calculates an index based the average distances | ||
| Nearest Neighbor Analysis calculates an index based on the average distances |
Collaborator
There was a problem hiding this comment.
Looks like this was already in the index.ts comment, just not populated into the readme. I thought we had pre-commit hooks to make sure that didn't happen. Oh well.
|
|
||
| // If simplified ring isn't valid (has been over simplified) reduce the | ||
| // tolerance by 1% and try again. | ||
| while (!checkValidity(simpleRing) && ringTolerance >= Number.EPSILON) { |
Collaborator
There was a problem hiding this comment.
I was worried about this leaving impossibly tiny polygons with a large number of points, but EPSILON is so much smaller than any meaningful coordinate delta that this is probably a nonissue.
> area({type: "Polygon", coordinates: [[0,0], [0, Number.EPSILON], [Number.EPSILON, Number.EPSILON], [Number.EPSILON, 0], [0, 0]]})
0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simplify was getting stuck in an infinite loop when it couldn't reduce the tolerance far enough to generate a valid polygon. This often happened with very small rings e.g. couple of centimetres to a side.
Resolves #1788
Please provide the following when creating a PR:
contributorsfield ofpackage.json- you've earned it! 👏