Added new point-to-polygon-distance package#2735
Added new point-to-polygon-distance package#2735smallsaucepan merged 6 commits intoTurfjs:masterfrom
Conversation
|
Looking good thanks @pachacamac. Glad to see it works with polygon holes as well. Before it's ready to merge we might need to flesh it out in a couple of areas:
Sorry if that's more involved than you expected. Happy to co-author though if your time is limited. |
|
Thanks for pointing out the options. Missed that I can just forward this to the |
|
@smallsaucepan anything else needed from my side? |
smallsaucepan
left a comment
There was a problem hiding this comment.
Thanks for this @pachacamac. Looks good.
One final task - could you please add this to the packages/turf/ package as well? That's the aggregator package that pulls in all the other turf-* packages for easy importing.
Pretty sure all you need to do is add point-to-polygon-distance as a package dependency, and re-export the main function from index.ts
|
@smallsaucepan done 👍 |
|
Thanks @pachacamac. Let's give it a spin through CI. |
…d. Re-adding new package as a dependency in my env and letting lock file regenerate to previous format.
|
Little bump in the road related to the pnpm-lock file. Pushed a quick fix and CI is green, so this is ready to merge 🎉 Thanks for your work on this @pachacamac. This was our most 👍-ed outstanding issue. |
Please fill in this template. Use a meaningful title for the pull request. Include the name of the package modified.
Submitting a new TurfJS Module.
./scripts/generate-readmesto createREADME.md.package.jsonusing "Full Name <@github Username>".Resolves #1743