Fixed confusing turf-union documentation#2732
Merged
smallsaucepan merged 2 commits intoTurfjs:masterfrom Oct 26, 2024
Merged
Conversation
…rded some of the descriptions as well.
twelch
approved these changes
Oct 26, 2024
Collaborator
twelch
left a comment
There was a problem hiding this comment.
I see the switch in the jsdoc from Feature to FeatureCollection. That looks correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been some confusion about what parameters union expects - see #1669, #1900, #2377 and #2657.
Docs are now in sync with the signature of the union function, which definitely does accept multiple polygons or multipolygons.
Resolves #1900
Resolves #2377
Resolves #2657