Merged
Conversation
Collaborator
|
I'm okay with upgrading just for maintenance sake, I think it reduces the amount of change at any one time, spreads it out. |
Collaborator
|
Do you think this PR is ready and useful to merge now? Or perhaps land after next release. |
Collaborator
Author
|
Lets land it after #2682 gets merged, that's probably the highest priority PR outstanding. |
2 tasks
Member
smallsaucepan
approved these changes
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supposedly this should give us performance gains, but I'm not seeing it in the PR build timings. I'm a little hesitant to upgrade Typescript just for maintenance sake because we've seen correctness issues internally with a bunch of our Typescript upgrades recently.
We may be able to leverage some of the newer features to clean up tsconfigs perhaps?