Skip to content

feat(@turf/boolean-contains): Add MultiPolygon support#2338

Merged
rowanwins merged 1 commit intoTurfjs:masterfrom
Debakel:multipolygon-contains-polygon
Oct 6, 2022
Merged

feat(@turf/boolean-contains): Add MultiPolygon support#2338
rowanwins merged 1 commit intoTurfjs:masterfrom
Debakel:multipolygon-contains-polygon

Conversation

@Debakel
Copy link
Copy Markdown
Contributor

@Debakel Debakel commented Sep 20, 2022

Adds support for MultiPolygons to booleanContains().

Closes #2337

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Have read How To Contribute.
  • Run npm test at the sub modules where changes have occurred.
  • Run npm run lint to ensure code style at the turf module level.

rowanwins
rowanwins approved these changes Oct 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rowanwins rowanwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great thanks @Debakel - I'm just waiting for CI to pass before merging. And the team is hoping that we'll get a release out soon

@rowanwins rowanwins merged commit 81bb457 into Turfjs:master Oct 6, 2022
@antonmelbardis
Copy link
Copy Markdown

antonmelbardis commented Nov 24, 2022

@rowanwins hi! When is this going to be released?

@rowanwins
Copy link
Copy Markdown
Member

rowanwins commented Nov 24, 2022

Hi @antonmelbardis - this should now be available in 7.0.0-alpha.0 which is available on npm

@antonmelbardis
Copy link
Copy Markdown

antonmelbardis commented Nov 24, 2022

@rowanwins thank you sir!

@nick-romano
Copy link
Copy Markdown

nick-romano commented Dec 2, 2022

fyi- still getting Error: feature2 MultiPolygon geometry not supported on 7.0.0-alpha.0

@antonmelbardis
Copy link
Copy Markdown

antonmelbardis commented Dec 2, 2022

@rowanwins @nick-romano yeah, the issue is still there unfortunately

@Debakel
Copy link
Copy Markdown
Contributor Author

Debakel commented Dec 2, 2022

fyi- still getting Error: feature2 MultiPolygon geometry not supported on 7.0.0-alpha.0

@antonmelbardis @nick-romano The PR implemented booleanContains(feature1, feature2) only for cases where feature1 is a MultiPolygon and feature2 is a Polygon. Reversed operands are still not supported (but seems like there's already another PR for this: #2357).

➡️ It's only possible to check wether a Polygon is contained by a MultiPolygon and not vice-versa.
➡️ It's currently not possible to check wether a MultiPolygon contains a Point, Line or any other geometry type than Polygon.

@markstos
Copy link
Copy Markdown

markstos commented Dec 2, 2022 •
edited
Loading

I'm looking for point(MultiPolygon, Point), but maybe there's another way to accomplish that.

Found it! booleanPointInPolygon(). This function could be worth a mention from the booleanContains() docs.

@nicolasperez19 nicolasperez19 mentioned this pull request Nov 5, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rowanwins rowanwins rowanwins approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

booleanContains with MultiPolygon

5 participants

@Debakel @antonmelbardis @rowanwins @nick-romano @markstos