Merged
Conversation
mfedderly
approved these changes
Jul 6, 2021
Collaborator
mfedderly
left a comment
There was a problem hiding this comment.
lgtm. Its a little weird that the meat of this lives in another repo. It introduces this issue where polygon-clipping depends on turf which depends on polygon-clipping, and that has the turf deps pinned at 5.x which is not great, but we already depended on this exactly polygon-clipping apparently so it isn't making things worse.
| // basic x 4,627 ops/sec ±25.23% (21 runs sampled) | ||
| // mask-outside x 3,892 ops/sec ±34.80% (15 runs sampled) | ||
| // multi-polygon x 5,837 ops/sec ±3.03% (91 runs sampled) | ||
| // overlapping x 22,326 ops/sec ±1.34% (90 runs sampled) |
Collaborator
Huh this is actually just devDependencies so we're good. There was another package somewhere that had the old turf libraries as actual dependencies. |
|
@mfedderly Thanks, finally! Just wondering if there's going to be a an actual release anytime soon? |
Collaborator
|
I'm probably not going to get to it in the next few weeks but maybe @rowanwins has some time. |
This was referenced Jul 10, 2021
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reworks the mask module to be much simpler.
It's a bit slower on some of the tests (like surprisingly so) although I haven't quite dug into why deeply, it's most likely something to do with the union operation being called when it probably doesn't need to be.This work was originally included in my v7 branch.
Resolves #1944
Resolves #1917
Resolves #2054
Resolves #1454
Before
After