Skip to content

Enable typescript strict mode#2126

Merged
mfedderly merged 8 commits intomasterfrom
mf/strict-mode
Jun 23, 2021
Merged

Enable typescript strict mode#2126
mfedderly merged 8 commits intomasterfrom
mf/strict-mode

Conversation

@mfedderly
Copy link
Copy Markdown
Collaborator

No description provided.

@mfedderly mfedderly requested a review from JamesLMilner June 23, 2021 11:43
@JamesLMilner
Copy link
Copy Markdown
Collaborator

@mfedderly what do you think about turning strict: true on in all the tsconfig.json files across the repo? That would actually ensure we are always strictly enabled going forward

@mfedderly
Copy link
Copy Markdown
Collaborator Author

All of the individual packages have this tsconfig:

{
  "extends": "../../tsconfig.shared.json",
  "compilerOptions": {
    "outDir": "dist/js"
  },
  "files": ["index.ts"]
}

By changing tsconfig.shared.json we change them all to enforce strict mode.

@JamesLMilner
Copy link
Copy Markdown
Collaborator

All of the individual packages have this tsconfig:

{
  "extends": "../../tsconfig.shared.json",
  "compilerOptions": {
    "outDir": "dist/js"
  },
  "files": ["index.ts"]
}

By changing tsconfig.shared.json we change them all to enforce strict mode.

Sorry, yes I missed this! Looks good :)

@mfedderly
Copy link
Copy Markdown
Collaborator Author

@JamesLMilner can you add the github approval so I can merge this later? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants