Skip to content

tumblr sometimes returns an empty json array for Attribution rather than an object #579

@mjharwood

Description

@mjharwood

Describe the bug

Unhandled exception parsing the json object returned from tumblr.

instead of:

 "content": [
    {
       "attribution": {
       "type": "link",
       "url": "https://64.media.tumblr.com/....."
        },
   },

it returns:

content": [
  {
     "attribution": [
      ],

To Reproduce
seems to be on occasional posts, no particular pattern to trigger it

Expected behavior
post is successfully downloaded

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • TumblThree version: 2.15.1.0 (running current master under VS)
  • OS: Windows 11

Additional context

This, and many other fields, are not used by the application so could just be removed / disabled in TumblrTaggedSearchJson : Content to prevent this issue. The json parser just skips fields that aren't mapped.

I can produce a PR if that would be helpful.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions