Skip to content

Added types for Papaparse#27810

Merged
EvanHahn merged 1 commit into
mainfrom
papaparse-types
May 11, 2026
Merged

Added types for Papaparse#27810
EvanHahn merged 1 commit into
mainfrom
papaparse-types

Conversation

@EvanHahn

@EvanHahn EvanHahn commented May 11, 2026

Copy link
Copy Markdown
Contributor

ref #27752

This change should have no user impact.

We use papaparse in a few places. Let's install types for it. Luckily, there were no type errors!

@coderabbitai

coderabbitai Bot commented May 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f3c6f495-4d3b-4e42-b080-b2cf593ddec2

📥 Commits

Reviewing files that changed from the base of the PR and between 14a3433 and 1aef65b.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • apps/posts/package.json
  • apps/posts/src/typings.d.ts
  • ghost/core/package.json
💤 Files with no reviewable changes (1)
  • apps/posts/src/typings.d.ts

Walkthrough

This PR adds the official @types/papaparse (version 5.5.2) package to the devDependencies of both apps/posts/package.json and ghost/core/package.json. It simultaneously removes the ambient TypeScript module declaration for papaparse from apps/posts/src/typings.d.ts. The change replaces a locally maintained ambient module with the standard type definitions package from DefinitelyTyped.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Added types for Papaparse' clearly and accurately summarizes the main change: adding TypeScript type definitions for the papaparse library across multiple package.json files.
Description check ✅ Passed The description is directly related to the changeset, explaining that types for papaparse are being installed, references a related PR, and notes no type errors were encountered.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch papaparse-types

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EvanHahn
Added types for Papaparse
1aef65b 
ref #27752

_This change should have no user impact._

We use `papaparse` in a few places. Let's install types for it. Luckily,
there were no type errors!
@codecov

codecov Bot commented May 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.55%. Comparing base (02f95c4) to head (1aef65b).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #27810      +/-   ##
==========================================
+ Coverage   73.51%   73.55%   +0.04%     
==========================================
  Files        1514     1510       -4     
  Lines      126422   126346      -76     
  Branches    15146    15139       -7     
==========================================
- Hits        92943    92939       -4     
+ Misses      32557    32484      -73     
- Partials      922      923       +1
Flag Coverage Δ
admin-tests 53.30% <ø> (+0.18%) ⬆️
e2e-tests 73.55% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EvanHahn EvanHahn enabled auto-merge (squash) May 11, 2026 14:49
@EvanHahn EvanHahn merged commit 3f4b9ad into main May 11, 2026
45 checks passed
@EvanHahn EvanHahn deleted the papaparse-types branch May 11, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EvanHahn