-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
Align zh translations with China mainland terminology. #25696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThis pull request updates Chinese locale translations across three Ghost configuration files (comments.json, ghost.json, and portal.json). The changes consist of retranslated UI strings with refined wording, adjusted terminology for consistency, and the addition of explicit item counts in certain translations. All modifications are purely textual—no functional logic, structural changes, or behavioral alterations are introduced. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi! @cathysarisky, I absolutely love Ghost. I use it for writing documentation, blogging, and more. This is my first contribution to the project, and certainly not my last. This time, I revised certain terms used to translate expressions specific to mainland China, making them more consistent with current mainland Chinese usage. Thank you for taking the time to review this PR. |
|
Hi @tyreseluo , thank you for this contribution, and welcome to the Ghost repo! @tommywong-theinitium, you most recently contributed to these translations. Do you have a few minutes to review these revisions and offer any feedback? Thank you! 🙏 |
|
"This PR modification applies solely to language conventions in mainland China." My understanding is that zh is zh-Hans (simplified Chinese), and is largely CN-specific, and we have zh-Hant for traditional Chinese, largely TW-specific. If we need additional localization option for zh-*, or for other codes like zh-CN to fall back to existing localization options (i.e. zh-CN results in the current zh translations), please let me know. :) |
@cathysarisky,In fact, Hong Kong(China) and Macau(China) also require their own set of standards, as their Chinese usage differs from that of Taiwan(China) , despite all three regions employing Traditional Chinese.🧐🧐🧐 |
|
Thanks for the image. If translators are identified who'd like to contribute generically-named and could probably be more correctly labeled 'zh-Hans' or 'zh-CN'. I've got some language code clean-up on my eventual to-do list, but we can't further split zh-Hant to locales without volunteers to provide those translations. |
|
Yes, I agree. Thank you again for your reply. |
|
@tommywong-theinitium - would you want to review these translations? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| "Join the discussion": "加入讨论", | ||
| "Just now": "刚刚", | ||
| "Load more ({amount})": "载入更多({amount})", | ||
| "Load more ({amount})": "加载更多({amount})条", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Classifier placed outside parentheses creates awkward Chinese
The translation "加载更多({amount})条" places the Chinese classifier 条 outside the parentheses, which will display as "加载更多(5)条". In Chinese, classifiers must immediately follow their numbers. This creates grammatically awkward output that contradicts the PR's goal of making translations "read more naturally." The original translation "载入更多({amount})" did not have this issue. Consider either moving 条 inside the parentheses ({amount}条) or restructuring the phrase.
|
Adding a note here for the record that the folks at The Initium reviewed this. |
|
Hi !@cathysarisky Thanks for merge this PR. As a native Chinese speaker, I can also ensure that the vast majority of translations and content for mainland China are accurate and error-free. if have any about China mainland translate content also can @ me. 🤝🤝🤝 |

PR Content
This branch tightens up the zh-CN wording; no new files added.
Net result: portal and comments Chinese strings read more naturally, with the last missing translation now covered.
This PR modification applies solely to language conventions in mainland China.
Related PR
Note
Improves zh-CN locale consistency and naturalness with mainland terminology.
comments.json,ghost.json, andportal.jsonto consistently use评论and姓名/名字, and clearer load/show hints"Subscription details"inghost.jsonWritten by Cursor Bugbot for commit 749a292. This will update automatically on new commits. Configure here.