Skip to content

Conversation

@tyreseluo
Copy link
Contributor

@tyreseluo tyreseluo commented Dec 11, 2025

PR Content

This branch tightens up the zh-CN wording; no new files added.

  • Updated ghost/i18n/locales/zh/ghost.json for subscription/comment phrasing aligned with mainland usage and filled the missing “Subscription details” translation.
  • Refined ghost/i18n/locales/zh/comments.json copy: consistent “评论/名字” terms and clearer load/show hints.
  • Smoothed ghost/i18n/locales/zh/portal.json wording across subscription, email preferences, and error messages for a more natural, consistent tone.

Net result: portal and comments Chinese strings read more naturally, with the last missing translation now covered.

This PR modification applies solely to language conventions in mainland China.

Related PR


Note

Improves zh-CN locale consistency and naturalness with mainland terminology.

  • Updates comments.json, ghost.json, and portal.json to consistently use 评论 and 姓名/名字, and clearer load/show hints
  • Refines subscription, email preference, unsubscribe, and error/invite-only messages for more natural zh-CN phrasing
  • Adds missing translation for "Subscription details" in ghost.json
  • Text-only changes to i18n files; no functional or API changes

Written by Cursor Bugbot for commit 749a292. This will update automatically on new commits. Configure here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 11, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

This pull request updates Chinese locale translations across three Ghost configuration files (comments.json, ghost.json, and portal.json). The changes consist of retranslated UI strings with refined wording, adjusted terminology for consistency, and the addition of explicit item counts in certain translations. All modifications are purely textual—no functional logic, structural changes, or behavioral alterations are introduced.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Homogeneous changes: All updates follow the same pattern (string translations), making this a repetitive review task rather than requiring varied reasoning per file.
  • No logic verification needed: Translations require accuracy checking but do not demand code logic or control flow analysis.
  • Areas for attention:
    • Verify consistency of terminology across the three files (e.g., "名字" vs. "姓名" for "name")
    • Confirm proper handling of parameter placeholders like {amount}, {date}, and {email} in updated strings
    • Validate that translated phrases convey the intended meaning and maintain appropriate tone for subscription and user-facing UI contexts
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Align zh translations with mainland terminology' clearly and directly describes the main change—updating Chinese translations across locale files to align with mainland China conventions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description clearly describes the changes: updates to zh-CN wording in locale files for more natural mainland terminology, with specific file changes mentioned and reasoning provided.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tyreseluo
Copy link
Contributor Author

Hi! @cathysarisky, I absolutely love Ghost. I use it for writing documentation, blogging, and more. This is my first contribution to the project, and certainly not my last.

This time, I revised certain terms used to translate expressions specific to mainland China, making them more consistent with current mainland Chinese usage.

Thank you for taking the time to review this PR.

@tyreseluo tyreseluo marked this pull request as ready for review December 11, 2025 09:04
@tyreseluo tyreseluo changed the title Align zh translations with mainland terminology. Align zh translations with China mainland terminology. Dec 11, 2025
@cathysarisky
Copy link
Member

Hi @tyreseluo , thank you for this contribution, and welcome to the Ghost repo!

@tommywong-theinitium, you most recently contributed to these translations. Do you have a few minutes to review these revisions and offer any feedback? Thank you! 🙏

@cathysarisky
Copy link
Member

"This PR modification applies solely to language conventions in mainland China."

My understanding is that zh is zh-Hans (simplified Chinese), and is largely CN-specific, and we have zh-Hant for traditional Chinese, largely TW-specific. If we need additional localization option for zh-*, or for other codes like zh-CN to fall back to existing localization options (i.e. zh-CN results in the current zh translations), please let me know. :)

@tyreseluo
Copy link
Contributor Author

tyreseluo commented Dec 11, 2025

"This PR modification applies solely to language conventions in mainland China."

My understanding is that zh is zh-Hans (simplified Chinese), and is largely CN-specific, and we have zh-Hant for traditional Chinese, largely TW-specific. If we need additional localization option for zh-*, or for other codes like zh-CN to fall back to existing localization options (i.e. zh-CN results in the current zh translations), please let me know. :)

@cathysarisky,In fact, Hong Kong(China) and Macau(China) also require their own set of standards, as their Chinese usage differs from that of Taiwan(China) , despite all three regions employing Traditional Chinese.🧐🧐🧐

like this:
image

@cathysarisky
Copy link
Member

Thanks for the image. If translators are identified who'd like to contribute generically-named and could probably be more correctly labeled 'zh-Hans' or 'zh-CN'. I've got some language code clean-up on my eventual to-do list, but we can't further split zh-Hant to locales without volunteers to provide those translations.

@tyreseluo
Copy link
Contributor Author

Yes, I agree. Thank you again for your reply.

@cathysarisky cathysarisky self-assigned this Dec 15, 2025
@cathysarisky
Copy link
Member

@tommywong-theinitium - would you want to review these translations? Thanks!

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

"Join the discussion": "加入讨论",
"Just now": "刚刚",
"Load more ({amount})": "载入更多({amount})",
"Load more ({amount})": "加载更多({amount})",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Classifier placed outside parentheses creates awkward Chinese

The translation "加载更多({amount})条" places the Chinese classifier outside the parentheses, which will display as "加载更多(5)条". In Chinese, classifiers must immediately follow their numbers. This creates grammatically awkward output that contradicts the PR's goal of making translations "read more naturally." The original translation "载入更多({amount})" did not have this issue. Consider either moving inside the parentheses ({amount}条) or restructuring the phrase.

Fix in Cursor Fix in Web

@cathysarisky
Copy link
Member

Adding a note here for the record that the folks at The Initium reviewed this.

@cathysarisky cathysarisky enabled auto-merge (squash) January 14, 2026 12:35
@cathysarisky cathysarisky merged commit 380b22d into TryGhost:main Jan 14, 2026
38 checks passed
@tyreseluo tyreseluo deleted the revise_zh_wording branch January 14, 2026 13:15
@tyreseluo
Copy link
Contributor Author

tyreseluo commented Jan 14, 2026

Hi !@cathysarisky Thanks for merge this PR.

As a native Chinese speaker, I can also ensure that the vast majority of translations and content for mainland China are accurate and error-free.

if have any about China mainland translate content also can @ me. 🤝🤝🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants