Skip to content

fixes #1838#2237

Closed
gimelfarb wants to merge 1 commit intoTryGhost:masterfrom
gimelfarb-forks:fix-1838-admin-ssl
Closed

fixes #1838#2237
gimelfarb wants to merge 1 commit intoTryGhost:masterfrom
gimelfarb-forks:fix-1838-admin-ssl

Conversation

@gimelfarb
Copy link
Contributor

  • adding forceAdminSSL: {redirect: true/false} option to allow 403 over non-SSL rather than redirect
  • adding urlSSL option to specify SSL variant of url
  • using urlSSL when redirecting to SSL (forceAdminSSL), if specified
  • dynamically patching .url property for view engine templates to use SSL variant over HTTPS connections (pass .secure property as view engine data)
  • using urlSSL in a "reset password" email, if specified
  • adding unit tests to test forceAdminSSL and urlSSL options
  • created a unit test utility function to dynamically fork a new instance of Ghost during the test, with different configuration options

- adding `forceAdminSSL: {redirect: true/false}` option to allow 403 over non-SSL rather than redirect
- adding `urlSSL` option to specify SSL variant of `url`
- using `urlSSL` when redirecting to SSL (forceAdminSSL), if specified
- dynamically patching `.url` property for view engine templates to use SSL variant over HTTPS connections (pass `.secure` property as view engine data)
- using `urlSSL` in a "reset password" email, if specified
- adding unit tests to test `forceAdminSSL` and `urlSSL` options
- created a unit test utility function to dynamically fork a new instance of Ghost during the test, with different configuration options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant