-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
Closed
Labels
affects:adminAnything relating to Ghost AdminAnything relating to Ghost Admin
Milestone
Description
To date we've had no management around our various frontend dependencies. As we switch to ember, we're going to want to use bower.
I think it would be really good to do this in master for our current setup and merge it back into the ember branch... thoughts?
We can probably put the majority of our dependencies in bower.json, and then run bower install as part of npm install:
https://github.com/stefanpenner/ember-app-kit/blob/master/package.json#L17
This should be reasonably straight forward to do, however there are a couple of considerations:
- what to do about our shared vs client dependencies - the intention was always that 'shared' should contain anything that might be shared between the admin client and the theme. This has become a little bit confused over time.
- /shared/vendor/showdown/github.js is a heavily modified version of the original used on both the client and server
- /client/assets/vendor/showdown/extensions/ghostdown.js is a custom extension used client side only to manage image uploads + deal with multiple underscores
If we can make a sensible decision about how to sort these bits out, this might even be a good candidate for a beginner issue?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
affects:adminAnything relating to Ghost AdminAnything relating to Ghost Admin