Converted file type utils to TypeScript and restored .jsonld in file allowlist

vershwal · vershwal · commit b2b2b0d115ce · 2026-03-18T18:43:24.000+05:30
diff --git a/ghost/core/core/server/services/files/file-type-utils.ts b/ghost/core/core/server/services/files/file-type-utils.ts
@@ -1,15 +1,15 @@
-const path = require('path');
-const mime = require('mime-types');
+import path from 'path';
+import {lookup} from 'mime-types';
 
-const CONTENT_TYPE_OVERRIDES = new Map([
+const CONTENT_TYPE_OVERRIDES = new Map<string, string>([
     ['.html', 'text/plain'],
     ['.htm', 'text/plain'],
     ['.js', 'text/plain'],
     ['.css', 'text/plain'],
     ['.xml', 'text/plain']
 ]);
 
-const BROWSER_RENDERABLE_TYPES = new Set([
+const BROWSER_RENDERABLE_TYPES = new Set<string>([
     'image/jpeg',
     'image/png',
     'image/gif',
@@ -34,26 +34,23 @@ const BROWSER_RENDERABLE_TYPES = new Set([
  * 1. Override map — forced to text/plain to prevent browser execution
  * 2. Browser-renderable — type preserved as safe for browser rendering
  * 3. Fallback — application/octet-stream to force download
- *
- * @param {string} filename
- * @returns {string} content type to store
  */
-function getStorageContentType(filename) {
+function getStorageContentType(filename: string): string {
     const ext = path.extname(filename).toLowerCase();
 
     const override = CONTENT_TYPE_OVERRIDES.get(ext);
     if (override) {
         return override;
     }
 
-    const mimeType = mime.lookup(ext);
+    const mimeType = lookup(ext);
     if (mimeType && BROWSER_RENDERABLE_TYPES.has(mimeType)) {
         return mimeType;
     }
 
     return 'application/octet-stream';
 }
 
-module.exports = {
+export {
     getStorageContentType
 };
diff --git a/ghost/core/core/shared/config/overrides.json b/ghost/core/core/shared/config/overrides.json
@@ -46,6 +46,7 @@
             "extensions": [
                 ".pdf",
                 ".json",
+                ".jsonld",
                 ".ods",
                 ".odt",
                 ".pptx",
diff --git a/ghost/core/package.json b/ghost/core/package.json
@@ -232,6 +232,7 @@
     "@types/bookshelf": "1.2.9",
     "@types/common-tags": "1.8.4",
     "@types/jsonwebtoken": "9.0.10",
+    "@types/mime-types": "3.0.1",
     "@types/node": "22.18.10",
     "@types/node-jose": "1.1.13",
     "@types/nodemailer": "6.4.20",
diff --git a/ghost/core/test/unit/server/data/importer/index.test.js b/ghost/core/test/unit/server/data/importer/index.test.js
@@ -42,7 +42,7 @@ describe('Importer', function () {
 
         it('gets the correct extensions', function () {
             assert(Array.isArray(ImportManager.getExtensions()));
-            assert.equal(ImportManager.getExtensions().length, 54);
+            assert.equal(ImportManager.getExtensions().length, 55);
             assert(ImportManager.getExtensions().includes('.csv'));
             assert(ImportManager.getExtensions().includes('.json'));
             assert(ImportManager.getExtensions().includes('.zip'));
@@ -108,7 +108,7 @@ describe('Importer', function () {
         });
 
         it('globs extensions correctly', function () {
-            const extGlob = '+(.jpg|.jpeg|.gif|.png|.svg|.svgz|.ico|.webp|.mp4|.webm|.ogv|.mp3|.wav|.ogg|.m4a|.pdf|.json|.ods|.odt|.pptx|.rtf|.txt|.xls|.xlsx|.xml|.apkg|.css|.csv|.doc|.docx|.epub|.gpx|.html|.ics|.ipynb|.js|.key|.kml|.md|.mobi|.mov|.otf|.pages|.paprikarecipes|.psd|.py|.skp|.woff|.woff2|.xlsb|.xlsm|.yaml|.zip|.markdown)';
+            const extGlob = '+(.jpg|.jpeg|.gif|.png|.svg|.svgz|.ico|.webp|.mp4|.webm|.ogv|.mp3|.wav|.ogg|.m4a|.pdf|.json|.jsonld|.ods|.odt|.pptx|.rtf|.txt|.xls|.xlsx|.xml|.apkg|.css|.csv|.doc|.docx|.epub|.gpx|.html|.ics|.ipynb|.js|.key|.kml|.md|.mobi|.mov|.otf|.pages|.paprikarecipes|.psd|.py|.skp|.woff|.woff2|.xlsb|.xlsm|.yaml|.zip|.markdown)';
             assert.equal(ImportManager.getGlobPattern(ImportManager.getExtensions()), extGlob);
             assert.equal(ImportManager.getGlobPattern(ImportManager.getDirectories()), '+(images|content|media|files)');
             assert.equal(ImportManager.getGlobPattern(JSONHandler.extensions), '+(.json)');
diff --git a/yarn.lock b/yarn.lock
@@ -10262,6 +10262,11 @@
   resolved "https://registry.yarnpkg.com/@types/methods/-/methods-1.1.4.tgz#d3b7ac30ac47c91054ea951ce9eed07b1051e547"
   integrity sha512-ymXWVrDiCxTBE3+RIrrP533E70eA+9qu7zdWoHuOmGujkYtzf4HQF96b8nwHLqhuf4ykX61IGRIB38CC6/sImQ==
 
+"@types/mime-types@3.0.1":
+  version "3.0.1"
+  resolved "https://registry.yarnpkg.com/@types/mime-types/-/mime-types-3.0.1.tgz#7fb74656179257c27cd48aa503eb918811727115"
+  integrity sha512-xRMsfuQbnRq1Ef+C+RKaENOxXX87Ygl38W1vDfPHRku02TgQr+Qd8iivLtAMcR0KF5/29xlnFihkTlbqFrGOVQ==
+
 "@types/mime@*":
   version "3.0.1"
   resolved "https://registry.yarnpkg.com/@types/mime/-/mime-3.0.1.tgz#5f8f2bca0a5863cb69bc0b0acd88c96cb1d4ae10"
