Change: Don't output duplicate ids for section headers.#20
Merged
TrueBrain merged 1 commit intoTrueBrain:masterfrom Jan 8, 2021
Merged
Change: Don't output duplicate ids for section headers.#20TrueBrain merged 1 commit intoTrueBrain:masterfrom
TrueBrain merged 1 commit intoTrueBrain:masterfrom
Conversation
TrueBrain
reviewed
Jan 8, 2021
3cf92f4 to
6a70fbd
Compare
TrueBrain
approved these changes
Jan 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per https://web.dev/duplicate-id-active/, it is not recommended to have multiple elements with the same id.
This changes the output for each section so that the anchor element points to the span (since the span contains the useful information, and as such should be the target for screen readers). I also merged the two anchor elements into one.