Skip to content

feat(cache): send an ETag header with rendered pages for better caching capabilities#499

Merged
TrueBrain merged 1 commit intomainfrom
etag
Aug 10, 2023
Merged

feat(cache): send an ETag header with rendered pages for better caching capabilities#499
TrueBrain merged 1 commit intomainfrom
etag

Conversation

@TrueBrain
Copy link
Copy Markdown
Owner

The ETag is a sha256 hash over the fully rendered page. In constrast to Last-Modified, this value is stable between different runs of the server. It only changes when there is an actual content change.

@TrueBrain TrueBrain added the preview Deploy this Pull Request to Preview label Aug 10, 2023
@TrueBrain TrueBrain force-pushed the etag branch 2 times, most recently from 5f71526 to c8ac133 Compare August 10, 2023 19:57
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 72.22% and project coverage change: -0.11% ⚠️

Comparison is base (1484045) 83.69% compared to head (d772425) 83.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
- Coverage   83.69%   83.59%   -0.11%     
==========================================
  Files          52       52              
  Lines        2773     2786      +13     
  Branches      429      434       +5     
==========================================
+ Hits         2321     2329       +8     
- Misses        342      344       +2     
- Partials      110      113       +3     
Files Changed Coverage Δ
truewiki/views/page.py 85.18% <68.75%> (-4.67%) ⬇️
truewiki/web_routes.py 72.04% <100.00%> (+0.17%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TrueBrain TrueBrain temporarily deployed to Preview August 10, 2023 20:04 — with GitHub Actions Inactive
…ng capabilities

The ETag is a sha256 hash over the fully rendered page. In constrast
to Last-Modified, this value is stable between different runs of
the server. It only changes when there is an actual content change.
@TrueBrain TrueBrain temporarily deployed to Preview August 10, 2023 20:20 — with GitHub Actions Inactive
@TrueBrain TrueBrain merged commit 5384a3e into main Aug 10, 2023
@TrueBrain TrueBrain deleted the etag branch August 10, 2023 20:32
@@ -1,4 +1,6 @@
import aiohttp

Check notice

Code scanning / CodeQL

Module is imported with 'import' and 'import from'

Module 'aiohttp' is imported with both 'import' and 'import from'.
@TrueBrain TrueBrain added preview Deploy this Pull Request to Preview and removed preview Deploy this Pull Request to Preview labels Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Deploy this Pull Request to Preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants