Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
=======================================
Coverage 83.69% 83.69%
=======================================
Files 52 52
Lines 2773 2773
Branches 430 429 -1
=======================================
Hits 2321 2321
Misses 342 342
Partials 110 110
☔ View full report in Codecov by Sentry. |
176c078 to
7064556
Compare
And favicon.ico is cached like all other static files. The reason for this change is because people find it annoying to wait for an updated image to appear. By allowing private caching, but require revalidation, this is avoided. Sadly it also means proxies will no longer cache the entry. As a bonus, we can now extend the cache time to an hour, so browsing the wiki is more smooth during that hour. Also, only cache uploads that have a Last-Modified header, as otherwise revalidation is pointless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And favicon.ico is cached like all other static files.
The reason for this change is because people find it annoying to
wait for an updated image to appear. By allowing private caching,
but require revalidation, this is avoided. Sadly it also means
proxies will no longer cache the entry.
As a bonus, we can now extend the cache time to an hour, so
browsing the wiki is more smooth during that hour.
Also, only cache uploads that have a Last-Modified header,
as otherwise revalidation is pointless.