Skip to content

feat(github): allow defining the URL to use for GitHub for user authentication#458

Merged
TrueBrain merged 1 commit intomainfrom
allow-different-github-url
May 24, 2023
Merged

feat(github): allow defining the URL to use for GitHub for user authentication#458
TrueBrain merged 1 commit intomainfrom
allow-different-github-url

Conversation

@TrueBrain
Copy link
Copy Markdown
Owner

As GitHub is IPv4-only, sometimes there is a need to proxy GitHub via other domains to enable IPv6 connectivity. For those cases, these settings are useful.

…ntication

As GitHub is IPv4-only, sometimes there is a need to proxy
GitHub via other domains to enable IPv6 connectivity. For
those cases, these settings are useful.
@codecov
Copy link
Copy Markdown

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 63.63% and project coverage change: -0.09 ⚠️

Comparison is base (503b328) 83.95% compared to head (b30d1c0) 83.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   83.95%   83.87%   -0.09%     
==========================================
  Files          52       52              
  Lines        2749     2759      +10     
  Branches      427      427              
==========================================
+ Hits         2308     2314       +6     
- Misses        333      337       +4     
  Partials      108      108              
Impacted Files Coverage Δ
truewiki/user/github.py 73.33% <63.63%> (-3.81%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TrueBrain TrueBrain merged commit 477dcd8 into main May 24, 2023
@TrueBrain TrueBrain deleted the allow-different-github-url branch May 24, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant